Tolerate spaces in extra capability values

Bug #1732787 reported by Nick Timkovich
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Blazar
Fix Released
High
Nick Timkovich

Bug Description

If resource properties are specified like `["==","$network_adapters.0.model","NetXtreme II BCM57810 10 Gigabit Ethernet (rev 10)"]` it chokes because the query string passed to the database gets chopped 3 times into 4 parts.

Patch: https://review.openstack.org/520797

Pierre Riteau (priteau)
Changed in blazar:
status: New → Confirmed
importance: Undecided → High
milestone: none → 0.4.0
assignee: nobody → Nick Timkovich (nicktimko)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to blazar (master)

Reviewed: https://review.openstack.org/520797
Committed: https://git.openstack.org/cgit/openstack/blazar/commit/?id=7d1b3b7002ce1c791003681e36f572c67291dc72
Submitter: Zuul
Branch: master

commit 7d1b3b7002ce1c791003681e36f572c67291dc72
Author: Nick Timkovich <email address hidden>
Date: Thu Nov 16 15:20:29 2017 -0600

    Tolerate spaces in extra capability values

    The intent behind limiting the split of the query string at all appears
    to be supporting values with spaces, but it's off-by-one, limiting the
    number of splits to 3 (4 parts max) rather than 3 parts max.

    This commit also generates new random values for variables id and
    computehost_id during each call to _get_fake_host_extra_capabilities()
    rather than just once, which is necessary to avoid a failing test due to
    duplicate id values.

    Closes-Bug: #1732787
    Change-Id: I8dc56aa983ca27763a63325810753148cb8d8ecd

Changed in blazar:
status: Confirmed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/blazar 0.4.0.0b2

This issue was fixed in the openstack/blazar 0.4.0.0b2 development milestone.

Changed in blazar:
milestone: 0.4.0 → queens-3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.