Warn when publishing to vivid and destination PPA field is left blank

[Olivier Tilloy]

This is a request to make it very explicit when landing a silo would result in pushing packages to the vivid archive (as opposed to the overlay PPA).

I was just bitten by this, with a landing request for oxide-qt that targetted vivid but where the destination PPA field had been left blank (the requester probably assumed that it was going to go to the overlay PPA by default, given that it’s the default behaviour for dual-landing silos).

Targetting the vivid archive is a valid use case for SRUs, but is probably not that common. Maybe display a warning when creating the request, or when attempting to publish it, or both? Bileto could even try to be clever about this by checking whether the description of the request contains "SRU", and omit the warning if it does.

[Barry Warsaw (barry)]

<robru> barry: user just wants a warning to appear when the ticket is
        configured as an SRU [12:07]
<robru> barry: where an SRU would be "series != xenial && !dest"
<robru> barry: so you'd have to add a div somewhere in index.html that says
        'warning: this is an SRU, are you sure that's what you want?' and then
        on the div you'd put an ng-hidden="" attribute with some logic on it.

[Robert Bruce Park (robru)]

Fixed in trunk, will roll production later today or tomorrow.