Missing driver_info for IPMI driver

[Sylvère K]

kayobe 16.0.1.dev2

missing "ipmi_address" from "driver_info" of driver IPMI.

the BMC have assigned IP and are contactable via ipmitool (lan).

expected behavior : for each node, "driver_info" should have the correct "ipmi_address" and "ipmi_username" and "ipmi_password" set to the default set in bifrost.yml or inspector.yml

[Sylvère K (sylvr)]

```
(bifrost-deploy)[root@seed-bifrost bifrost-18.0.1.dev3]# baremetal node validate 766951dc-25b4-4010-a466-04a4c86812ef
+------------+--------+-------------------------------------------------------------------------------------+
| Interface | Result | Reason |
+------------+--------+-------------------------------------------------------------------------------------+
| bios | False | Driver ipmi does not support bios (disabled or not implemented). |
| boot | False | Node 766951dc-25b4-4010-a466-04a4c86812ef does not have any port associated with it |
| console | False | Driver ipmi does not support console (disabled or not implemented). |
| deploy | False | Node 766951dc-25b4-4010-a466-04a4c86812ef does not have any port associated with it |
| firmware | False | Driver ipmi does not support firmware (disabled or not implemented). |
| inspect | True | |
| management | False | Missing the following IPMI credentials in node's driver_info: ['ipmi_address']. |
| network | True | |
| power | False | Missing the following IPMI credentials in node's driver_info: ['ipmi_address']. |
| raid | False | Driver ipmi does not support raid (disabled or not implemented). |
| rescue | False | Driver ipmi does not support rescue (disabled or not implemented). |
| storage | True | |
+------------+--------+-------------------------------------------------------------------------------------+
```

[Julia Kreger (juliaashleykreger)]

This doesn't seem like a bug, but there is insufficient information to really understand what is happening.

If the BMC reports 0.0.0.0 as it's IP address when we perform introspection, it is disregarded because it likely means DHCP is in use which is generally not avisable for management networks. Furthermore discovery of the BMC address requires the inband communicaitons channel to be enabled and it may be disabled. Often vendors now disable the inband ipmi communications channel by default.

As such, there really is not enough information here to understand if there is a bug.

[Sylvère K (sylvr)]

Link to the kayobe configuration used to deploy Ironic/Bifrost : https://forge.univ-lyon1.fr/p1919734/kayobe-config/-/tree/deployment?ref_type=heads

[Sylvère K (sylvr)]

Tests ran :
- IPMI credentials set in inspector.yml don't appear in the introspection rule for default IPMI credentials during playbook execution (`kayobe seed service deploy && kayobe seed deployment image build --force-rebuild`)
- the same credentials set in bifrost.yml do appear in the introspection rule during playbook execution
      In either cases, the credentials don't appear in the node driver_info.

Methodology used to re-trigger discovery and introspection of nodes :
- powering off the nodes
- deleting them in Bifrost/Ironic (baremetal node delete)
- running `kayobe seed service destroy`
- running `ipmitool -I lanplus chassis bootdev pxe` on all the nodes BMC (to be 100% sure they PXEboot)
- running `kayobe seed service deploy`
- powering on the nodes

[Sylvère K (sylvr)]

New error :
2024-07-17 09:04:42.991 2548 ERROR ironic_inspector.utils [None req-b893bc45-6038-47bf-a960-ae88cfbb21a3 - - - - - -] Rule bf2af567-41a5-56ad-8bc9-056ceed37951 was not found: sqlalchemy.exc.NoResultFound: No row was found when one was required
2024-07-17 09:04:42.991 2548 DEBUG ironic_inspector.main [None req-b893bc45-6038-47bf-a960-ae88cfbb21a3 - - - - - -] Returning error to client: Rule bf2af567-41a5-56ad-8bc9-056ceed37951 was not found error_response /var/lib/kolla/venv/lib64/python3.9/site-packages/ironic_inspector/main.py:141

[Sylvère K (sylvr)]

/var/log/kolla/ironic/ironic.log :

2024-07-18 09:11:09.276 2645 ERROR ironic.drivers.modules.inspect_utils [None req-7906f8c8-4350-4d1e-962b-4463691d26d0 - - - - - -] No nodes satisfy MAC addresses (7c:d3:0
a:bc:13:c8, 7c:d3:0a:bc:13:c6) and BMC address(s) (172.16.10.41, ::/0) during inspection lookup
2024-07-18 09:11:09.307 2645 ERROR ironic.conductor.inspection [None req-7906f8c8-4350-4d1e-962b-4463691d26d0 - - - - - -] Error when processing inspection data for node a
5d81103-e877-4d88-8b5b-d4fb54b844c4: ironic.common.exception.InvalidState: Can not transition from state 'enroll' on event 'wait' (no defined transition)

[Sylvère K (sylvr)]

IPA kernel parameter whitespace issue.
In /httpboot/pxelinux.cfg/default `ipa-inspection-callback-url` contain a space too much. Removing it fixes the issue.

```
#!ipxe

dhcp || reboot

goto introspect

:introspect
kernel http://192.168.2.1:8080/ipa.kernel ipa-inspection-callback-url= https://192.168.2.1:5050/v1/continue ipa-api-url=https://192.168.2.1:6385 systemd.journald.forward_to_console=yes BOOTIF=${mac} nofb nomodeset vga=normal ipa-collect-lldp=1 ipa-inspection-collectors=default,logs,pci-devices ipa-inspection-benchmarks= ipa-insecure=1 ipa-debug=1 initrd=ipa.initramfs
initrd http://192.168.2.1:8080/ipa.initramfs
boot
```

[Will Szumski (willjs)]

I have proposed a patch to bifrost here: https://review.opendev.org/c/openstack/bifrost/+/924476