dnsmasq fails to start when setting inventory_dhcp to true

[Jonathan Harker]

When using static dhcp by setting `inventory_dhcp: true`, the generated /etc/dnsmasq.conf file is invalid, causing dnsmasq to fail to start with the error: "bad dhcp-range at line 55 of /etc/dnsmasq.conf"

According to the dnsmasq man page, an ipv4 dhcp-range should take the form:
--dhcp-range=[tag:<tag>[,tag:<tag>],][set:<tag>,]<start-addr>[,<end-addr>|<mode>][,<netmask>[,<broadcast>]][,<lease time>]

The line generated from bifrost is:
dhcp-range=192.168.254.200,192.168.254.250,static,255.255.255.0,12h

I can get dnsmasq to successfully start after editing the line to be:
dhcp-range=192.168.254.0,static,255.255.255.0,12h

bifrost version: master (at 580ec8969b3f401d052148d1116e925773e87e6c)
dnsmasq version: 2.78-13.1
operating system: opensuse leap 42.3

[Jonathan Harker (jesusaurus)]

I've discovered that this issue only affects newer dnsmasq versions, and downgrading to version 2.71 will work with the configuration file generated by bifrost.

[Julia Kreger (juliaashleykreger)]

This has already been done in bifrost's config:

https://github.com/openstack/bifrost/blob/e41ed498324e527400b50897fbb8b51ac909db1e/playbooks/roles/bifrost-ironic-install/templates/dnsmasq.conf.j2#L67

Marking fix released as a result.