ussuri code is out of date - neutron.objects.common_types has been removed

[Corey Bryant]

Traceback is shown below. It appears bgpvpn needs to use common_types from neutron-lib.

Related change in neutron:
https://opendev.org/openstack/neutron/commit/b4972e246d972885e216d437eb192ef76e82e890

=========================
Failures during discovery
=========================
--- import errors ---
Failed to import test module: networking_bgpvpn.tests.unit.services.bagpipe.test_bagpipe
Traceback (most recent call last): File "/usr/lib/python3/dist-packages/unittest2/loader.py", line 456, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python3/dist-packages/unittest2/loader.py", line 395, in _get_module_from_name
    __import__(name)
  File "/build/networking-bgpvpn-12.0.0~b1~git2019121710.40fa37b/networking_bgpvpn/tests/unit/services/bagpipe/test_bagpipe.py", line 35, in <module>
    from networking_bgpvpn.neutron.services.service_drivers.bagpipe import bagpipe
  File "/build/networking-bgpvpn-12.0.0~b1~git2019121710.40fa37b/networking_bgpvpn/neutron/services/service_drivers/bagpipe/bagpipe.py", line 37, in <module>
    from networking_bgpvpn.neutron.services.service_drivers.bagpipe \
  File "/build/networking-bgpvpn-12.0.0~b1~git2019121710.40fa37b/networking_bgpvpn/neutron/services/service_drivers/bagpipe/bagpipe_v2.py", line 31, in <module>
    from networking_bagpipe.objects import bgpvpn as bgpvpn_objects
  File "/usr/lib/python3/dist-packages/networking_bagpipe/objects/bgpvpn.py", line 22, in <module>
    from neutron.objects import common_types
ImportError: cannot import name 'common_types' from 'neutron.objects' (/usr/lib/python3/dist-packages/neutron/objects/__init__.py)

[Thomas Morin (tmmorin-orange)]

This seems to me as fixed by https://review.opendev.org/#/c/664672/ (merged two weeks go)

Which version are you running ?

[Corey Bryant (corey.bryant)]

It's actually bagpipe that uses common_types but bgpvpn should depend on the fixed version of bagpipe.

[Thomas Morin (tmmorin-orange)]

In openstack CI this is not an issue because of internal logic in zuul that allows to specify "required-projects" [1] for which zuul will take appropriate git branches.

Until now we've not been able to express a dependency of bgpvpn to an unreleased/git version of bagpipe. If I can trust my memory this was due to the impossibility of requirements checking tool to support the use of git url in (test-)requirements.txt. Maybe this has changed since last time we tried.

This is something that can be fixed for pypi installation of networking-bgpvpn as soon as a beta is published on pypi.

[1] https://github.com/openstack/networking-bgpvpn/blob/master/.zuul.yaml#L7