test_router_association_update unit test is not reliable

[Thomas Morin]

The networking_bgpvpn.tests.unit.extensions.test_bgpvpn_routes_control.BgpvpnRoutesControlExtensionTestCase.test_router_association_update is unreliable, sometimes fails with:

ft1.1: networking_bgpvpn.tests.unit.extensions.test_bgpvpn_routes_control.BgpvpnRoutesControlExtensionTestCase.test_router_association_update_StringException: pythonlogging:'': {{{ERROR [neutron.api.extensions] Extension path '' doesn't exist!}}}
stderr: {{{
/home/zuul/src/git.openstack.org/openstack/networking-bgpvpn/.tox/py36/lib/python3.6/site-packages/paste/deploy/loadwsgi.py:22: DeprecationWarning: Parameters to load are deprecated. Call .resolve and .require separately.
  return pkg_resources.EntryPoint.parse("x=" + s).load(False)
}}}

Traceback (most recent call last):
  File "/home/zuul/src/git.openstack.org/openstack/networking-bgpvpn/.tox/py36/lib/python3.6/site-packages/neutron/tests/base.py", line 137, in func
    return f(self, *args, **kwargs)
  File "/home/zuul/src/git.openstack.org/openstack/networking-bgpvpn/networking_bgpvpn/tests/unit/extensions/test_bgpvpn_routes_control.py", line 110, in test_router_association_update
    content_type='application/%s' % self.fmt)
  File "/home/zuul/src/git.openstack.org/openstack/networking-bgpvpn/.tox/py36/lib/python3.6/site-packages/webtest/app.py", line 400, in put
    content_type=content_type,
  File "/home/zuul/src/git.openstack.org/openstack/networking-bgpvpn/.tox/py36/lib/python3.6/site-packages/webtest/app.py", line 759, in _gen_request
    expect_errors=expect_errors)
  File "/home/zuul/src/git.openstack.org/openstack/networking-bgpvpn/.tox/py36/lib/python3.6/site-packages/webtest/app.py", line 655, in do_request
    self._check_status(status, res)
  File "/home/zuul/src/git.openstack.org/openstack/networking-bgpvpn/.tox/py36/lib/python3.6/site-packages/webtest/app.py", line 687, in _check_status
    res)
webtest.app.AppError: Bad response: 400 Bad Request (not 200 OK or 3xx redirect for http://localhost/bgpvpn/bgpvpns/fc98f54b-5f97-4ed1-9304-9b5898baa2e0/router_associations/ace3f441-398e-4230-adb3-ff88b272ea96.json)
b'{"NeutronError": {"type": "HTTPBadRequest", "message": "Unrecognized attribute(s) \'advertise_extra_routes\'", "detail": ""}}'

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/600731

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/600731
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=8c226961a1e2976c1122610541369ce3386078a1
Submitter: Zuul
Branch: master

commit 8c226961a1e2976c1122610541369ce3386078a1
Author: Thomas Morin <email address hidden>
Date: Fri Sep 7 14:51:57 2018 +0200

    mark test_router_association_update unit test as unreliable

    This unit test rarely fails, but since it's run many
    times (py27,py35,py36,cover,lower-requirements), this end
    up happening not so rarely.

    Marking it unreliable will result in the test being marked
    SKIP instead of FAIL.

    Related-Bug: 1791256
    Change-Id: Ia36ee92317f76fbde2d8bc46caa03a4d17046777