cleanup callers to obsolete neutronclient extension

Bug #1761691 reported by Thomas Morin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-bgpvpn
In Progress
Undecided
Thomas Morin

Bug Description

Initially, networking-bgpvpn was providing extension to python-neutronclient to augment Client with methods for the BGPVPN API [1] (eg. list_network_associations). This code became obsolete when similar methods were added to python-neutronclient [2] (e.g. list_bgpvpn_network_associations).

We need to clean up callers to the old methods (if only to avoid confusion between old/new names, leading to people to try list_port_associations, which fails because the methods for port associations where added only to python-neutronclient with names such as list_bgpvpn_port_associations).

This can help identify a superset of the callers that need to be updated:

beagle search '(get|list|show|update|delete)_(network|router)_assoc([^a-z]|iation)' |grep -v def |grep -v driver

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-bgpvpn (master)

Fix proposed to branch: master
Review: https://review.openstack.org/561225

Changed in bgpvpn:
assignee: nobody → Thomas Morin (tmmorin-orange)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-bgpvpn (master)

Reviewed: https://review.openstack.org/561209
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=da2a8835dd4a15b64791b034ad1d96dca69055fb
Submitter: Zuul
Branch: master

commit da2a8835dd4a15b64791b034ad1d96dca69055fb
Author: Thomas Morin <email address hidden>
Date: Fri Apr 13 14:18:42 2018 +0200

    doc: update python API client documentation

    The documentation was still refering to the
    old methods provided by the networking-bgpvpn
    dynamic extension to neutronclient instead of
    the newer and more complete methods that have
    been in neutronclient since Ocata release.

    This change updates the documentation and examples,
    and adds code to document the method for port
    associations.

    Partial-Bug: 1761691
    Change-Id: Idd572530d64cd65cc0a606515bcf7f056c2b8745

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/561225
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=89683e8fc4ff0000c0408cab99b377841358747b
Submitter: Zuul
Branch: master

commit 89683e8fc4ff0000c0408cab99b377841358747b
Author: Thomas Morin <email address hidden>
Date: Fri Apr 13 15:25:10 2018 +0200

    dashboard: use new neutronclient

    This change updates the call to neutronclient to use
    the BGPVPN methods natively defined in python-neutronclient,
    rather than the ones defined by the dynamic extension to
    neutronclient from networking-bgpvpn (which are deprecated).

    Also removes use of mox at the same time.

    This change also makes the lower constraint job use
    neutron, horizon, networking-odl and networking-bagpipe
    from git, which is required to unbreak the CI right now.

    Change-Id: I7d399466f6577e4dd55b1a0fa5a92aab15e6eebb
    Partial-Bug: 1761691

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/561210
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=2f061ca51f4af69efbb200e318cf269faffe93af
Submitter: Zuul
Branch: master

commit 2f061ca51f4af69efbb200e318cf269faffe93af
Author: Thomas Morin <email address hidden>
Date: Fri Apr 13 14:22:45 2018 +0200

    heat: use BGPVPN API method from neutronclient

    With this change, heat code will use the BGPVPN API
    methods from neutronclient, instead of the ones dynamically
    added to neutronclient by the networking-bgpvpn module.

    This allows the heat plugin to be installed in an environment
    where networking-bgpvpn is not installed.

    Partial-Bug: 1761691
    Change-Id: Ibea29481662994c8b560bda45d4db534e924d42a

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-bgpvpn (master)

Fix proposed to branch: master
Review: https://review.openstack.org/570084

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-bgpvpn (master)

Reviewed: https://review.openstack.org/570084
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=3b503219acc2a25177c35886bbea7899efe68a7c
Submitter: Zuul
Branch: master

commit 3b503219acc2a25177c35886bbea7899efe68a7c
Author: Thomas Morin <email address hidden>
Date: Tue May 22 17:31:28 2018 -0700

    use new neutronclient (more)

    This is a follow-up on I7d399466f6577e4dd55b1a0fa5a92aab15e6eebb,
    which missed a few places were the old method names were still
    used.

    Change-Id: I9dc5ddf64a968ce433f9dd05b135f4263a12b8a0
    Partial-Bug: 1761691

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.