agent extension fails to clear a bgpvpn association

[Thomas Morin]

The processing in _is_last_bgpvpn_info [1] fails in the case where update_bgpvpn RPC was called prior to deletion of the association (or deletion of the BGPVPN), because the update_bgpvpn RPC call includes an 'id' (which is a BGPVPN id) which we shouldn't use, but which we copy into net_info. It is then present in net_info at [2], which makes the orig_info dict non-empty after the RT update and results in the code failing to identify that there is no BGPVPN association anymore.

[1] https://github.com/openstack/networking-bagpipe/blob/master/networking_bagpipe/agent/bgpvpn/agent_extension.py#L388
[2] https://github.com/openstack/networking-bagpipe/blob/master/networking_bagpipe/agent/bgpvpn/agent_extension.py#L546

[Thomas Morin (tmmorin-orange)]

worked on in https://review.openstack.org/#/c/510918/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/510918
Committed: https://git.openstack.org/cgit/openstack/networking-bagpipe/commit/?id=d51f4e85708add58c07ec6a795fc67b2ebac0033
Submitter: Jenkins
Branch: master

commit d51f4e85708add58c07ec6a795fc67b2ebac0033
Author: Thomas Morin <email address hidden>
Date: Tue Oct 10 17:48:06 2017 +0200

    bgpvpn agent extension: fix disassociate after update

    We need to ignore the 'id' attribute in the RPC dict
    for update_bgpvpn and delete_bgpvpn. It is a remain of
    past code, and useless, and it breaks the _is_last_bgpvpn_info
    method.

    This change also updates existing unit tests so that
    we emulate the reception of real RPCs from the neutron server
    for bgpvpn.

    Closes-Bug: 1722569
    Change-Id: I7c479ff60328c02761ac865bb11318b52f1427ec

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-bagpipe 8.0.0.0b1 development milestone.