Avoid having an RT multiple times in an RPC

[Thomas Morin]

The bagpipe driver for BGPVPN compiles the BGPVPN route_targets, import_targets, export_targets attibutes into one "import RTs" list and one "export RTs" list. The "import RTs" list contains the RT from route_targets and import_targets, and the "export RTs" list contains the RT from route_targets and export_targets.

Currently, the code [1] does not filter duplicates: e.g. an RT that is both in route_targets and import_targets will be present twice in the RPCs between neutron server and agents, and agents will also pass this RT twice to bagpipe-bgp.

It would be better to avoid this duplicate.

[1] https://github.com/openstack/networking-bgpvpn/blob/master/networking_bgpvpn/neutron/services/service_drivers/bagpipe/bagpipe.py#L239-L261

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/513670

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/513670
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=72119ca9728d9bd7a6094d0377f57c4930db6267
Submitter: Zuul
Branch: master

commit 72119ca9728d9bd7a6094d0377f57c4930db6267
Author: Cédric Savignan <email address hidden>
Date: Fri Oct 20 10:58:18 2017 +0200

    Filter duplicated RTs in compiled list

    The code does not filter duplicates: e.g. an RT that is both
    in route_targets and import_targets will be present twice in the
    RPCs between neutron server and agents, and agents will also pass
    this RT twice to bagpipe-bgp.

    This patch fix avoid duplicated RTs in compiled Import Targets and
    Export Targets lists.

    Change-Id: Ia5b76235c75f005e3c53f7cddc8e085376f5ebe1
    Closes-Bug: 1719589

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-bgpvpn 8.0.0.0b2 development milestone.