odl driver for bgpvpn should be moved to networking-odl and v2 type driver is needed

[Isaku Yamahata]

ODL driver for bgpvpn should live in networking-odl and v2 type driver should be written.

As discussed https://review.openstack.org/#/c/231321 and https://review.openstack.org/#/c/247096/
it's temporal solution for odl driver to be hosted in networking-bgpvpn.

It's two cycles since then, so please move the ODL driver to networking-odl and provide v2 driver for it in Ocata cycle.
If it's difficult in Ocata cycle, please provide reason for it.

[Vishal Thapar (vthapar)]

Plan is to add V2 driver only to networking-odl as OCata is going to be V2 by default. Can we retain V1 driver in bgpvpn for another release before we remove it in Pike?

[Mathieu Rohon (mathieu-rohon)]

Hi vishal,

I'm fine keeping the v1 in the net-bgpvpn tree, we will probably do the same for the opencontrail diver, but the question is how long will ODL support the V1 driver?

We should probably have a compatibility matrix in the net-bgpvpn doc.

[Thomas Morin (tmmorin-orange)]

I also agree to keep odl driver v1 in ocata.

+1 mathieu to the idea of adding a driver compatibility matrix in bgpvpn documentation.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/424064

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/431879

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/424064
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=28479a7a946e97657a53a8f83800e8e8afdf561c
Submitter: Jenkins
Branch: master

commit 28479a7a946e97657a53a8f83800e8e8afdf561c
Author: Vivekanandan Narasimhan <email address hidden>
Date: Mon Jan 23 16:29:19 2017 +0530

    OpenDaylight BGPVPN Version 2 Driver

    The Version 1 driver for BGPVPN resides in the
    networking-bgpvpn repository here:

    https://github.com/openstack/networking-bgpvpn/tree/master/networking_bgpvpn/
    neutron/services/service_drivers/opendaylight/odl.py

    It will be deprecated in next Openstack Pike release,
    as default will be version 2 driver for all services
    by that release for OpenDaylight deployments.

    TODO:
    The following will come in subsequent reviews:

    a. Full stack tests.

    b. Functional tests.

    c. Bring the delete_bgpvpn, delete_net_assoc and
    delete_router_assoc into precommit after fixing
    the base BGPVPN Plugin in networking-bgpvpn repo.

    d. Fix the BGPVPN Plugin to use the same DB transaction
    (that it uses to write to Openstack DB), when invoking
    _precommit of service-drivers.

    A bug has been raised to address both c and d
    inside networking-bgpvpn plugin here:
    https://bugs.launchpad.net/bgpvpn/+bug/1664637

    Closes-Bug: #1656903
    Partial-Bug: #1632117
    Co-Authored-by: Vishal Thapar <email address hidden>
    Change-Id: I08485db8f10f15591d70474a4b8546990d4de166

[Isaku Yamahata (yamahata)]

The basic patch has been merged. There are several followup issues. But they will be tracked by another report.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/431879
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=ffee38097709dd4091fb8709a70cf6c361ed60ee
Submitter: Jenkins
Branch: master

commit ffee38097709dd4091fb8709a70cf6c361ed60ee
Author: Vishal Thapar <email address hidden>
Date: Fri Feb 10 10:02:41 2017 +0530

    Log a deprecated warning for ODL v1 driver

    From Ocata release the new ODL BGPVPN Driver v2 is available and v1 diver
    is being deprecated. Add a warning log message to inform users of v1
    driver so they can switch to the new v2 driver.

    Change-Id: Id58f0df0b0825ad78dff586a1bea07a78a19ec05
    Partial-Bug: #1632117
    Depends-On: I08485db8f10f15591d70474a4b8546990d4de166