Unneded import of pdb.set_Trace at top of element.py

[Christopher Toth]

This is just a simple unused import and can be safely removed. I recommend using flake8 on the package.

[Peter Novotnak (r-peter-2)]

Yeah, what the heck!

I don't know how to use BZR but it's just a 2 line change. Not just in element.py but also in dammit.py too.

[Peter Novotnak (r-peter-2)]

Scratch that! My IDE also finds unused pdb.set_trace imports in:

_html5lib.py
test_htmlparser.py
test_soup.py
test_tree.py

[Leonard Richardson (leonardr)]

How big a problem is this for you? I can take it out but it's useful to me, when debugging, to drop in a breakpoint without having to add the import.

[Leonard Richardson (leonardr)]

I'm closing this issue because, as I said earlier, it's useful to me to have these imports in place while debugging. If speed is such a concern that the time it takes to import a module is an issue for you, you should switch to raw lxml.

[Christopher Toth (q-alpha)]

This is completely absurd.

The reason this bug is open in the first places is for places where pdb
may not be available, for instance in a py2exe build of the package.

If you need to debug, debug in development. don't push your debugging
code to break other peoples' production, it's literally nonsensical.

Please remove pdb from any released versions of this package.

t

On 7/16/2016 9:30 AM, Leonard Richardson wrote:
> I'm closing this issue because, as I said earlier, it's useful to me to
> have these imports in place while debugging. If speed is such a concern
> that the time it takes to import a module is an issue for you, you
> should switch to raw lxml.
>
> ** Changed in: beautifulsoup
> Status: Incomplete => Won't Fix
>

[Leonard Richardson (leonardr)]

Christopher,

Thanks for explaining why you filed this bug. Now that I understand _why_ pdb is a problem for you, I agree that it should be changed. I'm reopening this bug and I'll take out the imports.

I understand your frustration but I don't like your attitude. I frequently get bug reports that are underspecified and questions I consider uninformed or frivolous, but I know that taking out my frustrations on the person who "doesn't get it" isn't helpful.

[Leonard Richardson (leonardr)]

Imports removed in revision 404.