Edit New issue Add license headers to source files.

[Annie Sullivan]

Some chromium dependencies import this project and would require the presence of valid license headers in all source files.

[Leonard Richardson (leonardr)]

Can you elaborate? I see a license header here:

http://dev.chromium.org/developers/coding-style

But that's a Javascript comment and can't go into a Python file. What does a Chromium license header for a Python file look like?

I'm not against putting metadata into the codebase for the benefit of other software projects, but I can't do it for everyone, so it comes down to how much extra metadata it is and how much of a hassle it would be to maintain.

In revision 396 I've made sure that all source files have a __license__ statement. I don't know if that does what you want.

[Paweł Hajdan, Jr. (phajdan-jr-z)]

Hi, thanks for asking.

To clear up a possible confusion - sorry, no, http://bazaar.launchpad.net/~leonardr/beautifulsoup/bs4/revision/396 doesn't address this.

Comment format doesn't matter that much - there's no problem with converting e.g. JS/C++ comment "//" to python's "#".

Ideally, just put entire MIT license text in the header, like this (I've marked parts that I consider optional for the purpose of this bug):

<OPTIONAL>
# Beautiful Soup is made available under the MIT license:
#
# Copyright (c) 2004-2015 Leonard Richardson
#
</OPTIONAL>
# Permission is hereby granted, free of charge, to any person obtaining
# a copy of this software and associated documentation files (the
# "Software"), to deal in the Software without restriction, including
# without limitation the rights to use, copy, modify, merge, publish,
# distribute, sublicense, and/or sell copies of the Software, and to
# permit persons to whom the Software is furnished to do so, subject to
# the following conditions:
#
# The above copyright notice and this permission notice shall be
# included in all copies or substantial portions of the Software.
<OPTIONAL>
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
# BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
# ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
# CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
#
# Beautiful Soup incorporates code from the html5lib library, which is
# also made available under the MIT license. Copyright (c) 2006-2013
# James Graham and other contributors
</OPTIONAL>

If you have strong opinions about this, something shorter that would also work (although is less preferred) would be something similar to this:

<OPTIONAL>
# Copyright 2013 The Chromium Authors. All rights reserved.
</OPTIONAL>
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

Please let me know if you have any further questions.

[Leonard Richardson (leonardr)]

Revision 398 adds a comment to every source file referencing the license file.