license?

Bug #1294662 reported by Philippe Ombredanne
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Beautiful Soup
Fix Released
Undecided
Unassigned

Bug Description

Leonard
Just my 2 cents: you are the author, so you can do whatever you want of course, but using a plain MIT would be simpler for everyone IMHO.

You state BS4 is MIT licensed, but there is a subtle variation which makes it a tad different:

[...] ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE, DAMMIT.

The DAMNIT addition is fun for sure, but it means that if I have other libs that use a true MIT license I can just list copyrights and a single copy of a standard MIT license .
With BS4 I need to reproduce an extra copy of the license text, yours, with your text variation because this is what you asked for.
Removing the DAMNIT addition would be simpler imho. FWIW you do not use it everywhere: https://github.com/pombredanne/sycorax/blob/master/COPYING does not have it.

Also the bottom of your text has this:

Beautiful Soup incorporates code from the html5lib library, which is also made available under the MIT license.

I think you might not be meeting the attribution requirements for html5lib:
See https://github.com/html5lib/html5lib-python/blob/master/LICENSE

I.e. you would need to list the ht5mlib copyright:
Copyright (c) 2006-2013 James Graham and other contributors

and since your copy of the MIT is different, you would need to reproduce the html5lib version of their MIT i.e. the full text as listed here https://github.com/html5lib/html5lib-python/blob/master/LICENSE without the DAMNIT, which is not part of their MIT license.

Cordially
Philippe

description: updated
description: updated
description: updated
Revision history for this message
Leonard Richardson (leonardr) wrote :

Fixed in revision 358.

Changed in beautifulsoup:
status: New → Fix Committed
Revision history for this message
Philippe Ombredanne (pombredanne) wrote :

@leonardr : Thank you! you rock.

Changed in beautifulsoup:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.