Beautiful Soup

typo causes find() to be called frequently when building the tree

Bug #1020268 reported by Leonard Richardson
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Beautiful Soup
Fix Released
Undecided
Unassigned

Bug Description

Line 270 of __init__.py mentions self.tagStack[i].nsprefix. But the actual name of the attribute is 'prefix', not 'nsprefix'. This means that every _popToTag call invokes a find() call looking for a nonexistant <nsprefix> subtag. This slows down parsing times greatly for no reason.

See original description
Revision history for this message
Leonard Richardson (leonardr) wrote :

Fixed in revision 241.

description: updated
Changed in beautifulsoup:
status: New → Fix Committed
Revision history for this message
Leonard Richardson (leonardr) wrote :

As seen in bug 1020300, this bug also causes namespaced tags to be closed in the wrong places when the parse tree is being built.

Changed in beautifulsoup:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.