oslo.messaging API change broke keystone listener

[Juan Antonio Osorio Robles]

This is reflected in the py27 test failures we've been seeing lately:

2016-05-10 20:29:16.472 | Traceback (most recent call last):
2016-05-10 20:29:16.473 | File "/home/jenkins/workspace/gate-barbican-python27/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
2016-05-10 20:29:16.473 | return func(*args, **keywargs)
2016-05-10 20:29:16.473 | File "/home/jenkins/workspace/gate-barbican-python27/barbican/tests/queue/test_keystone_listener.py", line 315, in test_should_start
2016-05-10 20:29:16.473 | msg_server = keystone_listener.MessageServer(self.conf)
2016-05-10 20:29:21.204 | File "/home/jenkins/workspace/gate-barb2016-05-10 20:29:21.199 7152 INFO barbican.plugin.simple_certificate_manager [req-8d62f8e1-3783-46db-a456-8f8be3480903 - - - - -] Invoking notify_ca_is_unavailable()
2016-05-10 20:29:21.205 | 2016-05-10 20:29:21.200 7152 INFO barbican.plugin.simple_certificate_manager [req-8d62f8e1-3783-46db-a456-8f8be3480903 - - - - -] Invoking notify_certificate_is_ready()
2016-05-10 20:29:35.152 | ican-python27/barbican/queue/keystone_listener.py", line 156, in __init__
2016-05-10 20:29:35.152 | endpoints=[self])
2016-05-10 20:29:35.153 | File "/home/jenkins/workspace/gate-barbican-python27/barbican/queue/__init__.py", line 112, in get_notification_server
2016-05-10 20:29:35.153 | allow_requeue)
2016-05-10 20:29:35.153 | TypeError: __init__() takes exactly 3 arguments (5 given)

This is caused by the NotificationDispatcher's class arguments changing.

[Juan Antonio Osorio Robles (juan-osorio-robles)]

Fixed by https://review.openstack.org/#/c/314881/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/314881
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=66418ecdc7cbaa3fa6405d1f9eb409f8acdfe3e7
Submitter: Jenkins
Branch: master

commit 66418ecdc7cbaa3fa6405d1f9eb409f8acdfe3e7
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Wed May 11 09:29:41 2016 +0300

    Fix creation of notification server

    The parameters that the NotificationDispatcher receives changed
    recently, and the targets (with its priorities) and requeuing now
    depend on the server/listener. So this patch makes the change to
    remove those parameters from the creation of that object, and replace
    the MessageHandlingServer for a NotificationServer that can actually
    handle these things.

    Change-Id: Ifc9cfcbd7e80cdd451a79c579294873cbd220c39
    Closes-Bug: #1580461

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/barbican 3.0.0.0b2 development milestone.