Gates failing due to broken devstack lib of Barbican

[Bharath]

Devstack gates are failing due to broken devstack lib of Barbican. Below is the devstack setup log from one of the lbaas gates.

It could be due to the usage of "service_tenant_name" instead of "service_project_name" in https://github.com/openstack/barbican/blob/master/devstack/lib/barbican#L210

2016-02-23 05:38:12.537 | ++ /opt/stack/new/barbican/devstack/plugin.sh:source:L26: create_barbican_accounts
2016-02-23 05:38:12.538 | +++ /opt/stack/new/barbican/devstack/lib/barbican:create_barbican_accounts:L210: openstack project list
2016-02-23 05:38:12.539 | +++ /opt/stack/new/barbican/devstack/lib/barbican:create_barbican_accounts:L210: awk '/ / { print $2 }'
2016-02-23 05:38:13.228 | ++ /opt/stack/new/barbican/devstack/lib/barbican:create_barbican_accounts:L210: SERVICE_TENANT='ID
2016-02-23 05:38:13.228 | 40045e752e134754993d723e1a6515c4
2016-02-23 05:38:13.228 | 5dff649db44943bbbc237db11d4bb3b6
2016-02-23 05:38:13.228 | 7f94289cd24944b3be1fbb7169716910
2016-02-23 05:38:13.228 | bac0415cc3b545e799601998c348ed74'
2016-02-23 05:38:13.230 | +++ /opt/stack/new/barbican/devstack/lib/barbican:create_barbican_accounts:L211: openstack role list
2016-02-23 05:38:13.230 | +++ /opt/stack/new/barbican/devstack/lib/barbican:create_barbican_accounts:L211: awk '/ admin / { print $2 }'
2016-02-23 05:38:13.843 | ++ /opt/stack/new/barbican/devstack/lib/barbican:create_barbican_accounts:L211: ADMIN_ROLE=8ac0d3377f104c8587dd6eaebede6abf
2016-02-23 05:38:13.845 | +++ /opt/stack/new/barbican/devstack/lib/barbican:create_barbican_accounts:L218: openstack user create --password secretservice --project ID 40045e752e134754993d723e1a6515c4 5dff649db44943bbbc237db11d4bb3b6 7f94289cd24944b3be1fbb7169716910 bac0415cc3b545e799601998c348ed74 --email <email address hidden> barbican
2016-02-23 05:38:13.846 | +++ /opt/stack/new/barbican/devstack/lib/barbican:create_barbican_accounts:L218: grep ' id '
2016-02-23 05:38:13.846 | +++ /opt/stack/new/barbican/devstack/lib/barbican:create_barbican_accounts:L218: get_field 2
2016-02-23 05:38:13.847 | +++ /opt/stack/new/devstack/functions-common:get_field:L679: local data field
2016-02-23 05:38:13.847 | +++ /opt/stack/new/devstack/functions-common:get_field:L680: read data
2016-02-23 05:38:14.356 | usage: openstack user create [-h] [-f {json,shell,table,value,yaml}]
2016-02-23 05:38:14.356 | [-c COLUMN] [--max-width <integer>] [--noindent]
2016-02-23 05:38:14.356 | [--prefix PREFIX] [--domain <domain>]
2016-02-23 05:38:14.356 | [--project <project>]
2016-02-23 05:38:14.356 | [--project-domain <project-domain>]
2016-02-23 05:38:14.356 | [--password <password>] [--password-prompt]
2016-02-23 05:38:14.356 | [--email <email-address>]
2016-02-23 05:38:14.356 | [--description <description>]
2016-02-23 05:38:14.356 | [--enable | --disable] [--or-show]
2016-02-23 05:38:14.356 | <name>
2016-02-23 05:38:14.356 | openstack user create: error: unrecognized arguments: 5dff649db44943bbbc237db11d4bb3b6 7f94289cd24944b3be1fbb7169716910 bac0415cc3b545e799601998c348ed74 barbican
2016-02-23 05:38:14.381 | ++ /opt/stack/new/barbican/devstack/lib/barbican:create_barbican_accounts:L218: BARBICAN_USER=
2016-02-23 05:38:14.381 | ++ /opt/stack/new/barbican/devstack/lib/barbican:create_barbican_accounts:L219: openstack role add --project ID 40045e752e134754993d723e1a6515c4 5dff649db44943bbbc237db11d4bb3b6 7f94289cd24944b3be1fbb7169716910 bac0415cc3b545e799601998c348ed74 --user 8ac0d3377f104c8587dd6eaebede6abf
2016-02-23 05:38:14.891 | usage: openstack role add [-h] [--domain <domain> | --project <project>]
2016-02-23 05:38:14.891 | [--user <user> | --group <group>]
2016-02-23 05:38:14.891 | [--group-domain <group-domain>]
2016-02-23 05:38:14.891 | [--project-domain <project-domain>]
2016-02-23 05:38:14.891 | [--user-domain <user-domain>] [--inherited]
2016-02-23 05:38:14.891 | <role>
2016-02-23 05:38:14.891 | openstack role add: error: unrecognized arguments: 5dff649db44943bbbc237db11d4bb3b6 7f94289cd24944b3be1fbb7169716910 bac0415cc3b545e799601998c348ed74
2016-02-23 05:38:14.914 | + /opt/stack/new/barbican/devstack/lib/barbican:create_barbican_accounts:L1: exit_trap

[Bharath (bharathm)]

Fix proposed and merged. https://review.openstack.org/#/c/283509/1