HTTP Code 500 Returned on bad CA resource in URL
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Barbican |
Fix Released
|
High
|
Dave McCowan |
Bug Description
Recreate Steps
-------
$curl -H 'content-
{"cas": ["http://
$ curl -H 'content-
{"status": "ACTIVE", "updated": "2015-09-
$barbican dmccowan$ curl -H 'content-
{"code": 500, "description": "Certificate Authority retrieval failure seen - please contact site administrator.", "title": "Internal Server Error"}
Traceback:
----------------
2015-09-17 08:03:01.771 69275 ERROR barbican.
2015-09-17 08:03:01.771 69275 ERROR barbican.
2015-09-17 08:03:01.771 69275 ERROR barbican.
2015-09-17 08:03:01.771 69275 ERROR barbican.
2015-09-17 08:03:01.771 69275 ERROR barbican.
2015-09-17 08:03:01.771 69275 ERROR barbican.
2015-09-17 08:03:01.771 69275 ERROR barbican.
2015-09-17 08:03:01.771 69275 ERROR barbican.
2015-09-17 08:03:01.773 69275 INFO barbican.
{address space usage: 2636541952 bytes/2514MB} {rss usage: 71565312 bytes/68MB} [pid: 69275|app: 0|req: 4/4] 127.0.0.1 () {28 vars in 1972 bytes} [Thu Sep 17 08:03:01 2015] GET /v1/cas/
Changed in barbican: | |
status: | New → In Progress |
assignee: | nobody → Dave McCowan (dave-mccowan) |
Changed in barbican: | |
importance: | Undecided → High |
milestone: | none → liberty-rc1 |
Changed in barbican: | |
status: | Fix Committed → Fix Released |
Changed in barbican: | |
milestone: | liberty-rc1 → 1.0.0 |
Reviewed: https:/ /review. openstack. org/224979 /git.openstack. org/cgit/ openstack/ barbican/ commit/ ?id=5b08265cbf9 8681a22f6cc7e84 e23de3c967a64d
Committed: https:/
Submitter: Jenkins
Branch: master
commit 5b08265cbf98681 a22f6cc7e84e23d e3c967a64d
Author: Dave McCowan <email address hidden>
Date: Thu Sep 17 23:23:13 2015 -0400
Add function to catch unknown attributes in URI
Added a _lookup() function that will catch attribute after {CA_ID}/ in
the URI that does not match a supported keyword (cacert, intermediates, etc.)
Before this caused a 500 (server error) to be returned, now the correct
404 (not found) error is returned.
Change-Id: I0a15d4ebcbce58 a807c4f4852b08b 774c315ce0d