Be consistent on test tools and drivers

Bug #1490747 reported by Dave McCowan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Barbican
Fix Released
Medium
Fernando Diaz

Bug Description

Most of the time Barbican uses testr to run unit tests and functional tests.
   functionaltests/run_tests.sh
   tox -e py27

In one case Barbican uses nosetests
   tox -e functional

It would be better to use one tool for all.

One reason is test attributes. Nose only knows about nose attributes. Testr only knows about testtools attributes.
To benefit from using attributes, we need to pick one flavor.

One good use of test attributes is to mark those tests that can not be run in parallel with a tag such as "no_parallel", then when running tests only run those tests not marked so with the --parallel parameter.

description: updated
Fernando Diaz (diazjf)
Changed in barbican:
status: New → In Progress
assignee: nobody → Fernando Diaz (diazjf)
Revision history for this message
Fernando Diaz (diazjf) wrote :
Changed in barbican:
status: In Progress → Fix Committed
Revision history for this message
Kaitlin Farr (kaitlin-farr) wrote :

@diazjf, just a small note, I think the "In Progress" means you're working on it, "Fix Committed" means that patch has been merged, "Fix released" means that the latest release of the project includes your fix.

Changed in barbican:
status: Fix Committed → In Progress
Revision history for this message
Fernando Diaz (diazjf) wrote :

^^ I'll keep that in mind, Thanks Kaitlin.

Changed in barbican:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to barbican (master)

Reviewed: https://review.openstack.org/218117
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=e67ca803b9e4c53f3ce81fb835ca22a5df8f5fef
Submitter: Jenkins
Branch: master

commit e67ca803b9e4c53f3ce81fb835ca22a5df8f5fef
Author: Fernando Diaz <email address hidden>
Date: Fri Aug 28 01:38:39 2015 -0500

    Use testr for running functional tests and documentation

    Alters tox.ini to use testr rather than nosetests.
    Also, adds documentation on how to use tox to run a
    single functional test class.

    Change-Id: I1333ead397f338ee3da3d81b0e1de8e93283a2b5
    Closes-Bug: #1490747

Changed in barbican:
status: In Progress → Fix Committed
Changed in barbican:
milestone: none → liberty-rc1
Thierry Carrez (ttx)
Changed in barbican:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in barbican:
milestone: liberty-rc1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.