Remove uwsgi and pyenv from barbican.sh

Bug #1459814 reported by Douglas Mendizábal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Barbican
Invalid
Low
Douglas Mendizábal

Bug Description

uwsgi and pyenv are not required by Barbican, so they should not be required in the barbican.sh script.

Revision history for this message
John Wood (john-wood-w) wrote :

Please see this wishlist item as it calls for removing barbican.sh altogether: https://bugs.launchpad.net/barbican/+bug/1472427

Revision history for this message
Amy Marrich (amy-marrich) wrote :

This bug is now overriding https://bugs.launchpad.net/barbican/+bug/1472427 per redrobot and woodster. In addition to cleaning up the script renaming it to barbican-dev.sh..

Changed in barbican:
assignee: nobody → Amy Marrich (amy-marrich)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to barbican (master)

Fix proposed to branch: master
Review: https://review.openstack.org/211671

Changed in barbican:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to barbican (master)

Reviewed: https://review.openstack.org/211671
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=5696f5ef47daced4c8dc697aa287eee7f3dc153d
Submitter: Jenkins
Branch: master

commit 5696f5ef47daced4c8dc697aa287eee7f3dc153d
Author: Amy Marrich <email address hidden>
Date: Tue Aug 11 11:29:56 2015 -0500

    Removes pyenv from barbican.sh

    pyenv no longer rehashed as part of the installation

    Change-Id: Iae80d6342e7356f4fb949c4c10a048048d585351
    Closes-Bug: #1459814

Changed in barbican:
status: In Progress → Fix Committed
Changed in barbican:
status: Fix Committed → In Progress
importance: Undecided → Medium
Changed in barbican:
importance: Medium → Low
Revision history for this message
Alexis Rivera (gardlt) wrote :

so i am looking at the barbican.sh all its doing is installing the uwsgi and and falling back to the pydev if not the uwsgi. is this file needed. ???? the only thing of value would be the install section minus the uwsgi install cmd

Changed in barbican:
assignee: Amy Marrich (amy-marrich) → German Rivera (gr720e)
Revision history for this message
Dave McCowan (dave-mccowan) wrote :

barbican.sh is a developer's tool. it has install, start, stop, restart, and debug options. all of those are important to developers.

Revision history for this message
Alexis Rivera (gardlt) wrote :

so all that start and stop is kill and start uwsgi. debug run pydev or uwsgi. and install uwsgi which is needed by start and stop. this ticket states that they want to remove or make their install of those two optional. What is it that the ticket is asking us to do then or is the ticket invalid?

Revision history for this message
Douglas Mendizábal (dougmendizabal) wrote :

We should probably rename barbican.sh to barbican-dev.sh and clean up any unneeded dependencies.

Changed in barbican:
assignee: German Rivera (gr720e) → nobody
Alexis Rivera (gardlt)
Changed in barbican:
assignee: nobody → German Rivera (gerrivera)
Alexis Rivera (gardlt)
Changed in barbican:
assignee: German Rivera (gerrivera) → nobody
Revision history for this message
Jeremy Liu (liujiong) wrote :

I agree with @Douglas Mendizábal

Changed in barbican:
assignee: nobody → Douglas Mendizábal (dougmendizabal)
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.