Reconfigure image loading path for scenario tests

[Chris Hoge]

After reviewing the scenario test options and code path at the Kilo Design Summit, we determined that the options related to Amazon images needed to be removed as they introduce a failure path:

aki_img_file
ami_img_file
ari_img_file

The `img_dir` option also needs to be removed in favor of using a full path for `img_file`.

[Jason Wong (wantwatering)]

Which means scenario tests such as test_large_ops and test_encrypted_cinder_volumes won't prepare their own images any more?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/185174

[Matthew Treinish (treinish)]

@Jason Wong sorry I missed your comment on this before. To answer your question, no the scenario tests will still upload their own images if they were before. All this bug is saying that the config options around this will be simplified significantly, instead of having 2 sets of of options to use either a single file image or the 3 file ec2 images and then having a non-obvious convoluted fallback logic in place between them. This will be simplified to just be the options for a single file image, additionally we'll stop using a split img_dir and img_file and just switch to a single option with a full path.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/267670

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/267679

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/267670
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=5d5e20a2ee4644b31207027cbe0c02d07bf11b5d
Submitter: Jenkins
Branch: master

commit 5d5e20a2ee4644b31207027cbe0c02d07bf11b5d
Author: Matthew Treinish <email address hidden>
Date: Thu Jan 14 10:54:30 2016 -0500

    Mark amazon image file config options deprecated

    This commit marks the 4 options used in the scenario section as
    deprecated. The behavior of these options and the other image file
    options in the scenario section have a very convoluted and difficult
    to understand. There is no reason for this complexity we should just
    have a single option to tell tempest where the image file is. As the
    first step in cleaning this up this marks the options which will be
    removed as deprecated to signal to users the future change here.

    Partial Bug: #1393881

    Change-Id: I8a6ee167384c8a2d17905db3a4061c06398980ad

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emily Hugenbruch (<email address hidden>) on branch: master
Review: https://review.openstack.org/185174
Reason: Bug got fixed under another patch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/338377

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matthew Treinish (<email address hidden>) on branch: master
Review: https://review.openstack.org/267679

[chandan kumar (chkumar246)]

Unassigning this bug as there is no activity from last 6 months. If you are still want to work on this bug, feel free to assign yourself.

[Vishakha Agarwal (vishakha.agarwal)]

Hi,

Is anybody working on this issue?

Thanks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/710996

[Martin Kopec (mkopec)]

for the record, be aware of this LP: https://bugs.launchpad.net/tempest/+bug/1740258

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/710996
Committed: https://git.openstack.org/cgit/openstack/tempest/commit/?id=02af6a44cccc01990fbaa697cea5881e097a1a98
Submitter: Zuul
Branch: master

commit 02af6a44cccc01990fbaa697cea5881e097a1a98
Author: Martin Kopec <email address hidden>
Date: Tue Mar 3 12:39:12 2020 +0000

    Remove deprecated scenario image options

    Let's remove deprecated scenario image options which have been
    deprecated for more than 4 years.

    From now on CONF.scenario.img_file will need a full path for the image.
    CONF.scenario.img_dir was deprecated and will be removed in the next
    release. Till Tempest 25.0.0, old behavior is maintained and keep working
    but starting Tempest 26.0.0, you need to specify the full path
    in CONF.scenario.img_file config option.

    Change-Id: I96d26ad3889f55d867fdea016953cce522a6fbdf
    Related-Bug: #1393881

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/754927

[Martin Kopec (mkopec)]

We can't proceed with https://review.opendev.org/#/c/754927/ at the moment. We need to wait until the oldest OpenStack release tested in the gates has at least tempest 25 or higher, currently tempest 25 made it to Ussuri https://review.rdoproject.org/r/#/c/29616/ and Train https://review.rdoproject.org/r/#/c/29611/, however it's not in Stein.

[Martin Kopec (mkopec)]

We still can't proceed with https://review.opendev.org/c/openstack/tempest/+/754927 although upstream gates for train, ussuri and victoria use tempest from master because the devstack change https://review.opendev.org/c/openstack/devstack/+/712634 is part of devstack only from victoria onward.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tempest 27.0.0 release.

[Martin Kopec (mkopec)]

https://review.opendev.org/c/openstack/tempest/+/754927 got merged and it's part of Tempest 27.0.0 (see the previous comment)