Getting decrypted secret fails due to missing transport_key arg in store_crypto.py

Bug #1354603 reported by Adam Harwell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Barbican
Fix Released
Medium
Adam Harwell

Bug Description

In commit cd70a208c621400c3a26efccdf0a3135ff6ed44b the non-optional argument "transport_key" was added to the __init__ of SecretDTO in barbican/plugin/interface/secret_store.py but was not added to all of the code usages of this class. Specifically, barbican/plugin/store_crypto.py on line 108 in StoreCryptoAdapterPlugin.get_secret() only passes 4 args not 5.
It seems that the arg was originally meant to be optional, so it should be changed to "transport_key=None".

Old:
    def __init__(self, type, secret, key_spec, content_type, transport_key):

New:
    def __init__(self, type, secret, key_spec, content_type,
                 transport_key=None):

Revision history for this message
Adam Harwell (adam-harwell) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to barbican (master)

Reviewed: https://review.openstack.org/113044
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=e246a74c52d7d8941f971ef8000764fcaa161e0f
Submitter: Jenkins
Branch: master

commit e246a74c52d7d8941f971ef8000764fcaa161e0f
Author: Adam Harwell <email address hidden>
Date: Fri Aug 8 18:05:19 2014 -0500

    Make transport_key an optional arg in SecretDTO

    Change-Id: I4ab224e0484c99fbfdf5c6ea3d10e69a8c762d88
    Closes-Bug: #1354603

Changed in barbican:
status: New → Fix Committed
Thierry Carrez (ttx)
Changed in barbican:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in barbican:
milestone: juno-3 → 2014.2
Changed in barbican:
importance: Undecided → Medium
assignee: nobody → Adam Harwell (adam-harwell)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.