Design trouble on account_statement_one_move, avoiding the call to super()

Bug #1317064 reported by Joël Grand-Guillaume @ camptocamp on 2014-05-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Banking Addons
Undecided
Unassigned

Bug Description

Hi,

In the account_statement_one_move, we have a trouble. I had unfortunately no time to investigate more, but wanted to warn people about what I saw:

 * If you use the group move option on a profile, then it didn't call super(account_bank_statement, self).create_move_from_st_line() => so if you have any other module that need to do something here, it won't !

 * I sometimes had one proper move generated, and some time a variable number of moves. I didn't figured out why or in which contexte, sorry.

 * It seems that this module isn't compatible with account_default_draft_move nor with account_constraints (thought some work has been done to make it work with the last one by passing "context['from_parent_object'] = True", but this is a work around, because what we want is to call super in ANY case)

 * The design of the whole bank_statemnet is not made to support this use case, looking in the "create_move_from_st_line" function, you will see this. We call this method for each statement line and compute the bank and counter part account for every of them. Making one move will imply to change that logic everywhere. Remember that this method is part of the addons :(

I tried to figure those problem out in that MP here but didn't succeed and found no clean solution :https://code.launchpad.net/~camptocamp/banking-addons/bank-statement-reconcile-7.0-one-move-fix-jge/+merge/209867

I have no real idea on how to solve this, any suggestion is welcome, but for know, I want to suggest marking this module "account_statement_one_move" as installable = False to avoid people use it.

Regards,

Related branches

My instance was installed with the following modules at least:

addons :
-----------
account_accountant

account-financial-tools:
--------------------------------
account_constraints
account_default_draft_move

bank-statement-reconcile:
------------------------------------
account_invoice_reference
account_statement_base_completion
account_statement_base_import
account_statement_ext
account_statement_commission
invoicing_voucher_killer
statement_voucher_killer
account_advanced_reconcile
account_statement_transactionid_import
account_advanced_reconcile_transaction_ref
account_statement_transactionid_completion

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers