[6.1] Banking addons: AttributeError: 'bool' object has no attribute 'upper'

[Erwin van der Ploeg (BAS Solutions)]

Hello,

On importing a Mt940 Raboban statement i get an error

Traceback (most recent call last):
  File "C:\Program Files\OpenERP 6.1\Server\server\.\openerp\osv\osv.py", line 121, in wrapper
  File "C:\Program Files\OpenERP 6.1\Server\server\.\openerp\osv\osv.py", line 176, in execute
  File "C:\Program Files\OpenERP 6.1\Server\server\openerp\addons\audittrail\audittrail.py", line 495, in execute_cr
  File "C:\Program Files\OpenERP 6.1\Server\server\.\openerp\osv\osv.py", line 164, in execute_cr
  File "C:\Program Files\OpenERP 6.1\Server\server\openerp\addons\account_banking\wizard\bank_import.py", line 316, in import_statements_file
  File "C:\Program Files\OpenERP 6.1\Server\server\openerp\addons\account_banking\banking_import_transaction.py", line 1359, in match
  File "C:\Program Files\OpenERP 6.1\Server\server\openerp\addons\account_banking\banking_import_transaction.py", line 300, in _match_invoice
AttributeError: 'bool' object has no attribute 'upper'

I have solved it by changing 2 lines in: account_banking/banking_import_transaction.py

from:
299 ref = trans.reference.upper()
300 msg = trans.message.upper()

to:
299 ref = trans.reference and trans.reference.upper() or ''
300 msg = trans.message and trans.message.upper() or ''

So, hope this is ok and can be adopted in code.

[Ruchir Shukla(BizzAppDev) (ruchir.shukla)]

Please find the attached Patch file for the same .