Banking Addons

If exist two partners with same name statement importing fails

Bug #1085113 reported by Paulius Sladkevičius @ hbee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Banking Addons
Fix Released
Low
Stefan Rijnhart (Opener)

Bug Description

get_or_create_partner method can return 'False' if exist more then one partner with same name. But if this case happens then create_bank_account fails too.

Please check http://bazaar.launchpad.net/~banking-addons-team/banking-addons/6.1/view/head:/account_banking/banking_import_transaction.py#L1308

Related branches

lp:~therp-nl/banking-addons/ab6.1-lp1085113-take_first_of_two_partners_with_same_name
Stefan Rijnhart (Opener): Needs Resubmitting
Guewen Baconnier @ Camptocamp: Approve
Paulius Sladkevičius @ hbee: Pending requested
Diff: 31 lines (+8/-6)
1 file modified
account_banking/wizard/banktools.py (+8/-6)
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Paulius,

what behaviour would you like to see instead?

Cheers,
Stefan.

Revision history for this message
Paulius Sladkevičius @ hbee (komsas) wrote :

Hi Stefan,

I was thinking about two solutions:
1. take first of partner when got more the 1 partner
2. raise error

Stefan Rijnhart (Opener) (stefan-opener)
Changed in banking-addons:
status: New → Triaged
status: Triaged → Fix Committed
importance: Undecided → Low
assignee: nobody → Stefan Rijnhart (Therp) (stefan-therp)
Stefan Rijnhart (Opener) (stefan-opener)
Changed in banking-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.