Search queries are not escaped

Bug #1234336 reported by Alejandro J. Cura
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Won't Fix
High
Alejandro J. Cura
unity-scope-click (Ubuntu)
Won't Fix
Low
Unassigned

Bug Description

The search query can't have a comma, or it will interpreted as a different part of the solr search.
Also, it should be urlencoded to account for special characters.

dobey (dobey)
affects: unity-scope-click → unity-scope-click (Ubuntu)
Revision history for this message
Jonas Platte (jplatte) wrote :

This might be why searching for "Yahoo" displays three apps, "Yahoo! Mail" being on of them (although the "Yahoo! Finance" scope is not found, which is probably another bug), but "Yahoo!" yields no search results at all.

dobey (dobey)
Changed in unity-scope-click (Ubuntu):
assignee: Alejandro J. Cura (alecu) → nobody
importance: Medium → Critical
dobey (dobey)
Changed in unity-scope-click (Ubuntu):
importance: Critical → High
Changed in canonical-devices-system-image:
assignee: nobody → Alejandro J. Cura (alecu)
importance: Undecided → High
milestone: none → backlog
status: New → Confirmed
Changed in unity-scope-click (Ubuntu):
assignee: nobody → Marcus Tomlinson (marcustomlinson)
status: Triaged → In Progress
Changed in canonical-devices-system-image:
status: Confirmed → In Progress
dobey (dobey)
Changed in unity-scope-click (Ubuntu):
importance: High → Medium
Changed in unity-scope-click (Ubuntu):
assignee: Marcus Tomlinson (marcustomlinson) → nobody
status: In Progress → Confirmed
Changed in canonical-devices-system-image:
status: In Progress → Confirmed
Changed in canonical-devices-system-image:
status: Confirmed → Won't Fix
Changed in unity-scope-click (Ubuntu):
status: Confirmed → Won't Fix
Changed in band-aids-uphone:
status: New → Opinion
Revision history for this message
dobey (dobey) wrote :

We don't quite want to fix this at the moment, as currently it allows passing of elasticsearch parameters in the query, which we rely on for testing, and for which is the only way to filter results in some ways currently. For example "price:0.00" will show all the free apps and "name:com.ubuntu.terminal" will show only the terminal app. Escaping characters would break many of the options here.

We previously had a proposed branch to fix this, but we did not merge it for these reasons.

Changed in unity-scope-click (Ubuntu):
importance: Medium → Low
no longer affects: band-aids-uphone
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.