bamf tests need to cleanup dbus resources

Bug #1088696 reported by Francis Ginther on 2012-12-10
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BAMF
High
Marco Trevisan (Treviño)
0.4
High
Marco Trevisan (Treviño)
bamf (Ubuntu)
Undecided
Unassigned
Raring
Undecided
Unassigned

Bug Description

[Impact]

This fix is necessary also from the point of view of daily-release and automerging on jenkins - otherwise jenkins was trashed with hanging processes.

[Test Case]

1. Run the headless unit tests (make test-headless)
2. Make sure there are no leftover dbus-daemon's running afterwards

[Regression Potential]

Broken DBus on the test system, most unlikely.

Original description:

The bamf integration tests do not cleanup the dbus-daemon process. This results in two process left open after every bamf build on the jenkins autolanding environment. This may be a contributing factor to some test failures as the builds tend to be more successful after cleaning up these dbus-daemon processes on the build machines. The processes look like this:

# ps -ef|grep dbus-daemon
1234 13257 1 0 22:04 ? 00:00:00 //bin/dbus-daemon --fork --print-pid 5 --print-address 7 --session
1234 13854 1 0 22:04 ? 00:00:00 //bin/dbus-daemon --fork --print-pid 4 --print-address 6 --session
...

Related branches

Changed in bamf:
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in bamf:
status: New → In Progress
milestone: none → 0.5.0
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:bamf at revision 542, scheduled for release in bamf, milestone 0.5.0

Changed in bamf:
status: In Progress → Fix Committed
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:bamf/0.4 at revision 540, scheduled for release in bamf, milestone 0.4.1

description: updated
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bamf - 0.5.0daily13.06.19-0ubuntu1

---------------
bamf (0.5.0daily13.06.19-0ubuntu1) saucy; urgency=low

  [ Marco Trevisan (Treviño) ]
  * New upstream release, bumping debian version to 0.5.0
  * LibBamfPrivate: add new private library to share code between client
    and daemon.
  * libbamf, BamfView: Use dbus-properties (both values and signals) It
    allows to have correct values and signals when they get updated.
    Deprecating related dbus methods/signals.
  * debian/control:
    - don't build-depend anymore on libdbus-glib-1-dev

  [ Jeremy Bicha ]
  * debian/control:
    - Have libbamf3-dev depend on gir1.2-bamf-3
    - Drop explicit build-depends on gir1.2-glib-2.0

  [ Ted Gould ]
  * Have bamfdaemon depend on the library instead of vice versa.

  [ Marco Trevisan (Treviño) ]
  * Makefile.am.gtests: kill the launched dbus-daemon after running the
    tests. (LP: #1088696, #1186915)
  * BamfDaemon, LibBamf: Fix compilation errors out from ubuntu. (LP:
    #1186915, #1176524)
  * BamfView: use statically allocated pspec to notify property changes
    BamfFactory: some initial cleanup, remove views that have changed
    their path and use cached children.
  * BamfView: use incremental children caching, delete them only when
    daemon stops Each view used to cleanup the cached children every
    time a new one was added or removed. This was needed at the dbus-
    glib times to handle the case of bamfdaemon restart, but now we can
    handle this nicely, clening the children up only when this happens.
  * BamfView: disconnect proper callback if a bamf-tab is closed I guess
    it was a typo, we need to disconnect to the callback we've been
    connected to before.
  * BamfView: don't try to reload the children if they're empty but we
    already tried once This finally mutes the "Unable to fetch children"
    warning... \o/. (LP: #943083)
  * Bamf: use generic marshallers when creating signals, remove legacy
    bamf-marshal Improvements to the build system, fixed "make
    distcheck" (it was still referencing the old bamf.h file) and
    generation of files when using parallel builds (make -jX).
  * BamfMatcher: If a Window has changed its class, then we try to
    rematch it This is mostly the case of LibreOffice, but if a window
    has changed its class, then we should try to re-match, checking if
    now it can be matched by a new application. If this is the case,
    then we remove the window from the previous application (that may
    eventually be closed) and we add it to the new one. Thanks to this
    we can finally remove a lot of libreoffice-only related code.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 554
 -- Ubuntu daily release <email address hidden> Wed, 19 Jun 2013 02:01:25 +0000

Changed in bamf (Ubuntu):
status: New → Fix Released

Hello Francis, or anyone else affected,

Accepted bamf into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/bamf/0.4.0daily13.06.19~13.04-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in bamf (Ubuntu Raring):
status: New → Fix Committed
tags: added: verification-needed
tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bamf - 0.4.0daily13.06.19~13.04-0ubuntu1

---------------
bamf (0.4.0daily13.06.19~13.04-0ubuntu1) raring; urgency=low

  [ Marco Trevisan (Treviño) ]
  * Makefile.am.gtests, Makefile.am.coverage: add missing entries to
    allow building in jenkins. (LP: #1192216)
  * Makefile.am.gtests: kill the launched dbus-daemon after running the
    tests. (LP: #1088696)

  [ Łukasz 'sil2100' Zemczak ]
  * Automatic snapshot from revision 540

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 541

bamf (0.4.0daily13.05.31~13.04-0ubuntu1) raring; urgency=low

  [ Marco Trevisan (Treviño) ]
  * Releasing Bamf-0.4.0
  * libbamf: BamfApplication: cache MimeTypes and ApplicationType on
    favorite and sticky apps. (LP: #1183871)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 536

bamf (0.4.0daily13.05.08~13.04-0ubuntu1) raring; urgency=low

  [ Marco Trevisan (Treviño) ]
  * debian/control:
    - Update the libwnck-3-dev dependency to 3.4.5

  [ Timo Jyrinki ]
  * Set Vcs-Bzr url to 0.4 for this raring branch

  [ Marco Trevisan (Treviño) <mail@3v1n0.net>, Alexandre Abreu ]
  * Webapps launchers have incorrect window matching (pips) (LP:
    #1059475)

  [ Marco Trevisan (Treviño) ]
  * Coverity SECURE_TEMP - CID 10450 (LP: #1100551)
  * Matcher leaks memory when rematching a new desktop file (LP:
    #1169990)
  * Coverity DEADCODE - CID 10447 (LP: #1100554)
  * Coverity REVERSE_INULL - CID 12653 (LP: #1100553)
  * Webapps launchers have incorrect window matching (pips) (LP:
    #1059475)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 533
 -- Ubuntu daily release <email address hidden> Wed, 19 Jun 2013 02:01:50 +0000

Changed in bamf (Ubuntu Raring):
status: Fix Committed → Fix Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Fix Released in Bamf BAMF 0.5.0.

Changed in bamf:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers