Coverity UNINIT - CID 10451

Bug #937402 reported by Product Strategy Coverity Bug Uploader on 2012-02-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
BAMF
Low
Unassigned
Legacy
Low
Unassigned
Unity
Fix Released
Undecided
Unassigned
bamf (Ubuntu)
Undecided
Unassigned
unity (Ubuntu)
Undecided
Unassigned

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 10451
Checker: UNINIT
Category: pointer_deref_read
CWE definition: http://cwe.mitre.org/data/definitions/457.html
File: /tmp/buildd/bamf-0.2.106/tests/bamfdaemon/test-view.c
Function: test_path_collision()
Code snippet:
147 static void
148 test_path_collision (void)
149 {
150 BamfView *view;
CID 10451 - UNINIT
Declaring variable "views" without initializer.
151 GList *views, *l;
152 int i, j;
153
At conditional: "i < 20" taking True branch
154 for (i = 0; i < 20; i++)
155 {
At conditional: "j < 2000" taking True branch
156 for (j = 0; j < 2000; j++)

Related branches

Source file with Coverity annotations.

Changed in bamf:
importance: Undecided → High
Charles Kerr (charlesk) wrote :

At first I thought this was another instance of Coverity being paranoid, but it looks like we do start prepending to "views" without initializing it to NULL...

Didier Roche (didrocks) on 2012-03-12
Changed in unity:
status: New → Fix Committed
milestone: none → 5.6.0
Didier Roche (didrocks) on 2012-03-12
Changed in bamf:
status: Fix Committed → Fix Released
Changed in unity:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bamf - 0.2.112-0ubuntu1

---------------
bamf (0.2.112-0ubuntu1) precise; urgency=low

  * New upstream release.
    - bamf matcher messes up refcounting on views (LP: #942070)
    - Chromium is running, but not showing in launcher or alt-tab.
      (LP: #918474)
    - libbamf leaks memory on view dispose (LP: #942148)
    - Coverity PW.PARAMETER_HIDDEN - CID 10449 (LP: #937398)
    - Coverity UNINIT - CID 10451 (LP: #937402)
  * debian/libbamf0.symbols, debian/libbamf3-0.symbols:
    - update symbols for new API
 -- Didier Roche <email address hidden> Mon, 12 Mar 2012 11:47:33 +0100

Changed in bamf (Ubuntu):
status: New → Fix Released
Adolfo Jayme (fitojb) on 2014-01-11
no longer affects: bamf (Ubuntu Quantal)
Changed in unity (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers