Implicit functions declarations in bamf-matcher.c

[Maxime Gauduin]

Trying to build latest bzr on Arch Linux with GCC 4.8 fails because of implicit functions declarations in src/bamf-matcher.c (-Werror=implicit-function-declaration is set). Please find attached a build log.

[Maxime Gauduin (alucryd)]

Here's a patch that fixes it. Added the needed include, and moved the function declaration after the ifdef.

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:bamf at revision 543, scheduled for release in bamf, milestone 0.5.0

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "bamf-matcher.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Maxime Gauduin (alucryd)]

Commit 543 did not fix, it only adds the missing header. I still run into:

‘bamf_matcher_has_tab_with_parent_xid’ defined but not used [-Werror=unused-function]

The patch I attached above fixed both the missing header and this error. Here's a new patch with only the fix for this error.

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:bamf at revision 547, scheduled for release in bamf, milestone 0.5.0

[Launchpad Janitor (janitor)]

This bug was fixed in the package bamf - 0.5.0daily13.06.19-0ubuntu1

---------------
bamf (0.5.0daily13.06.19-0ubuntu1) saucy; urgency=low

  [ Marco Trevisan (Treviño) ]
  * New upstream release, bumping debian version to 0.5.0
  * LibBamfPrivate: add new private library to share code between client
    and daemon.
  * libbamf, BamfView: Use dbus-properties (both values and signals) It
    allows to have correct values and signals when they get updated.
    Deprecating related dbus methods/signals.
  * debian/control:
    - don't build-depend anymore on libdbus-glib-1-dev

  [ Jeremy Bicha ]
  * debian/control:
    - Have libbamf3-dev depend on gir1.2-bamf-3
    - Drop explicit build-depends on gir1.2-glib-2.0

  [ Ted Gould ]
  * Have bamfdaemon depend on the library instead of vice versa.

  [ Marco Trevisan (Treviño) ]
  * Makefile.am.gtests: kill the launched dbus-daemon after running the
    tests. (LP: #1088696, #1186915)
  * BamfDaemon, LibBamf: Fix compilation errors out from ubuntu. (LP:
    #1186915, #1176524)
  * BamfView: use statically allocated pspec to notify property changes
    BamfFactory: some initial cleanup, remove views that have changed
    their path and use cached children.
  * BamfView: use incremental children caching, delete them only when
    daemon stops Each view used to cleanup the cached children every
    time a new one was added or removed. This was needed at the dbus-
    glib times to handle the case of bamfdaemon restart, but now we can
    handle this nicely, clening the children up only when this happens.
  * BamfView: disconnect proper callback if a bamf-tab is closed I guess
    it was a typo, we need to disconnect to the callback we've been
    connected to before.
  * BamfView: don't try to reload the children if they're empty but we
    already tried once This finally mutes the "Unable to fetch children"
    warning... \o/. (LP: #943083)
  * Bamf: use generic marshallers when creating signals, remove legacy
    bamf-marshal Improvements to the build system, fixed "make
    distcheck" (it was still referencing the old bamf.h file) and
    generation of files when using parallel builds (make -jX).
  * BamfMatcher: If a Window has changed its class, then we try to
    rematch it This is mostly the case of LibreOffice, but if a window
    has changed its class, then we should try to re-match, checking if
    now it can be matched by a new application. If this is the case,
    then we remove the window from the previous application (that may
    eventually be closed) and we add it to the new one. Thanks to this
    we can finally remove a lot of libreoffice-only related code.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 554
 -- Ubuntu daily release <email address hidden> Wed, 19 Jun 2013 02:01:25 +0000

[Marco Trevisan (Treviño) (3v1n0)]

Fix Released in Bamf BAMF 0.5.0.