LibreOffice Base Unity integration, has incorrect icon in launcher
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| BAMF |
Medium
|
Marco Trevisan (Treviño) | ||
| 0.2 |
Medium
|
Marco Trevisan (Treviño) | ||
| 0.3 |
Medium
|
Marco Trevisan (Treviño) | ||
| bamf (Ubuntu) |
Undecided
|
Marco Trevisan (Treviño) | ||
| Precise |
Medium
|
Timo Jyrinki | ||
| Quantal |
Undecided
|
Marco Trevisan (Treviño) |
Bug Description
[IMPACT]
Incorrect icon][
[TEST CASE]
Libreoffice base not show correct icon, show a libreoffice blank icon.
[REGRESSION POTENTIAL]
Little, the fix includes comprehensive automated testing for the issue.
Related branches
- Łukasz Zemczak: Approve on 2012-10-11
- Brandon Schaefer (community): Approve on 2012-10-10
-
Diff: 1051 lines (+429/-112)19 files modifiedsrc/bamf-legacy-window-test.c (+62/-13)
src/bamf-legacy-window-test.h (+6/-2)
src/bamf-legacy-window.c (+27/-7)
src/bamf-legacy-window.h (+11/-3)
src/bamf-matcher.c (+25/-29)
src/bamf-unity-webapps-tab.c (+0/-1)
src/bamf-window.c (+5/-5)
src/bamf-window.h (+1/-1)
src/bamf-xutils.c (+55/-40)
src/bamf-xutils.h (+2/-2)
tests/bamfdaemon/data/libreoffice-base.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-calc.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-draw.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-impress.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-math.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-startcenter.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-writer.desktop (+7/-0)
tests/bamfdaemon/test-matcher.c (+166/-9)
tests/bamfdaemon/test-window.c (+20/-0)
- Brandon Schaefer (community): Approve on 2012-10-10
- jenkins: Pending (continuous-integration) requested 2012-10-10
-
Diff: 1051 lines (+429/-112)19 files modifiedsrc/bamf-legacy-window-test.c (+62/-13)
src/bamf-legacy-window-test.h (+6/-2)
src/bamf-legacy-window.c (+27/-7)
src/bamf-legacy-window.h (+11/-3)
src/bamf-matcher.c (+25/-29)
src/bamf-unity-webapps-tab.c (+0/-1)
src/bamf-window.c (+5/-5)
src/bamf-window.h (+1/-1)
src/bamf-xutils.c (+55/-40)
src/bamf-xutils.h (+2/-2)
tests/bamfdaemon/data/libreoffice-base.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-calc.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-draw.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-impress.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-math.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-startcenter.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-writer.desktop (+7/-0)
tests/bamfdaemon/test-matcher.c (+166/-9)
tests/bamfdaemon/test-window.c (+20/-0)
- Brandon Schaefer (community): Approve on 2012-10-10
-
Diff: 1039 lines (+429/-111)18 files modifiedsrc/bamf-legacy-window-test.c (+62/-13)
src/bamf-legacy-window-test.h (+6/-2)
src/bamf-legacy-window.c (+27/-7)
src/bamf-legacy-window.h (+11/-3)
src/bamf-matcher.c (+25/-29)
src/bamf-window.c (+5/-5)
src/bamf-window.h (+1/-1)
src/bamf-xutils.c (+55/-40)
src/bamf-xutils.h (+2/-2)
tests/bamfdaemon/data/libreoffice-base.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-calc.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-draw.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-impress.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-math.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-startcenter.desktop (+7/-0)
tests/bamfdaemon/data/libreoffice-writer.desktop (+7/-0)
tests/bamfdaemon/test-matcher.c (+166/-9)
tests/bamfdaemon/test-window.c (+20/-0)
Dan Jared (danjaredg) wrote : | #1 |
Changed in bamf: | |
importance: | Undecided → Medium |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
milestone: | none → 0.3.4 |
status: | New → Triaged |
Changed in bamf (Ubuntu): | |
status: | New → Confirmed |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in bamf: | |
milestone: | 0.3.4 → 0.4.0 |
Changed in bamf (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in bamf: | |
status: | Triaged → In Progress |
Changed in bamf: | |
status: | In Progress → Fix Committed |
Dan Jared (danjaredg) wrote : | #2 |
Changed in bamf (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in bamf (Ubuntu Precise): | |
importance: | Undecided → High |
status: | New → Triaged |
Changed in bamf (Ubuntu Precise): | |
importance: | High → Medium |
description: | updated |
Clint Byrum (clint-fewbar) wrote : | #3 |
The diff is 29,000+ lines long, but bamf does not have a micro release exception. Can you include a comprehensive list of all the changes and a testing plan? Otherwise we need to extract only the documented bug fix here.
Clint Byrum (clint-fewbar) wrote : | #4 |
(last comment was regarding the upload to quantal-proposed)
Hello Dan, or anyone else affected,
Accepted bamf into quantal-proposed. The package will build now and be available at http://
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-
Further information regarding the verification process can be found at https:/
tags: | added: verification-needed |
Dan Jared (danjaredg) wrote : | #6 |
Hi Steve,
The libreoffice base works well, great job, but the dialog windows aren't attached to libreoffice-base icon... watch the image attached
tags: |
added: verification-failed removed: verification-needed |
Timo Jyrinki (timo-jyrinki) wrote : | #7 |
Hi Dan. I just tested it, and it's true that dialog windows aren't matched correctly yet. However it is not a regression, and it seems that the matching works for the main window ie. this bug. I filed a new bug #1072642 about the dialog windows.
tags: |
added: verification-done removed: verification-failed |
Launchpad Janitor (janitor) wrote : | #8 |
This bug was fixed in the package bamf - 0.3.4-0ubuntu1
---------------
bamf (0.3.4-0ubuntu1) quantal-proposed; urgency=low
[ Timo Jyrinki ]
* New upstream release.
- Autoconf: Make libunity-webapps an optional dependency (on by default)
- Libbamf: Some signal, type and annotation fixes
- libbamf: gir-annotion fixes and make gi-scanner verbose
- Autoconf: Exclude generated sources from tarball and fix "make
distcheck".
- BamfMatcher: add support for libreoffice Base, and libreoffice matching
tests (LP: #1063862)
[ Didier Roche ]
* debian/
- Fix bamf.index perl script generation to fix UOA g-c-c panel associated
with empathy. (LP: #1045223)
-- Didier Roche <email address hidden> Wed, 17 Oct 2012 07:49:01 +0200
Changed in bamf (Ubuntu Quantal): | |
status: | Fix Committed → Fix Released |
Steve Langasek (vorlon) wrote : Update Released | #9 |
The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.
Launchpad Janitor (janitor) wrote : | #10 |
This bug was fixed in the package bamf - 0.3.4-0ubuntu1
---------------
bamf (0.3.4-0ubuntu1) quantal-proposed; urgency=low
[ Timo Jyrinki ]
* New upstream release.
- Autoconf: Make libunity-webapps an optional dependency (on by default)
- Libbamf: Some signal, type and annotation fixes
- libbamf: gir-annotion fixes and make gi-scanner verbose
- Autoconf: Exclude generated sources from tarball and fix "make
distcheck".
- BamfMatcher: add support for libreoffice Base, and libreoffice matching
tests (LP: #1063862)
[ Didier Roche ]
* debian/
- Fix bamf.index perl script generation to fix UOA g-c-c panel associated
with empathy. (LP: #1045223)
-- Didier Roche <email address hidden> Wed, 17 Oct 2012 07:49:01 +0200
Changed in bamf (Ubuntu): | |
status: | Fix Committed → Fix Released |
Changed in bamf (Ubuntu Precise): | |
status: | Triaged → In Progress |
assignee: | nobody → Timo Jyrinki (timo-jyrinki) |
Changed in bamf (Ubuntu Precise): | |
milestone: | none → ubuntu-12.04.2 |
Hello Dan, or anyone else affected,
Accepted bamf into precise-proposed. The package will build now and be available at http://
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-
Further information regarding the verification process can be found at https:/
Changed in bamf (Ubuntu Precise): | |
status: | In Progress → Fix Committed |
tags: | removed: verification-done |
tags: | added: verification-needed |
Timo Jyrinki (timo-jyrinki) wrote : | #12 |
Works with precise-proposed.
tags: |
added: verification-done removed: verification-needed |
Launchpad Janitor (janitor) wrote : | #13 |
This bug was fixed in the package bamf - 0.2.124.2-0ubuntu1
---------------
bamf (0.2.124.
* New upstream release.
- Includes all previous cherry-picks
- Daemon, BamfApplication: Use the default icon if there is not
one defined in the desktop file. (LP: #886778)
- BamfMatcher: don't reopen windows when iterating on view's
list, add tests. (LP: #1082298)
- BamfMatcher: add support for libreoffice Base, and libreoffice
matching tests (LP: #1063862)
-- Timo Jyrinki <email address hidden> Wed, 28 Nov 2012 15:42:28 +0200
Changed in bamf (Ubuntu Precise): | |
status: | Fix Committed → Fix Released |
Changed in bamf: | |
status: | Fix Committed → Fix Released |
thanks Marco for this fixed