Bake

Bake does not build on Mac OSX

Bug #1217437 reported by Chris Molozian on 2013-08-27

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Bake	Triaged	Medium	Unassigned

Bug Description

I'm not sure this is a bug with bake but it would be fantastic if there was a workaround that could be implemented to allow bake to be built on Mac OS X.

I get these errors when I build the codebase:

```
$ make
valac -o bake-template --pkg=posix src/bake-template.vala
/Users/novabyte/Desktop/bake/src/bake-template.vala.c:477:2: warning: 'g_type_init' is deprecated [-Wdeprecated-declarations]
        g_type_init ();
        ^
/usr/local/Cellar/glib/2.36.4/include/glib-2.0/gobject/gtype.h:669:23: note: 'g_type_init' declared here
void g_type_init (void);
                      ^
1 warning generated.
valac -o bake-test --pkg=posix src/bake-test.vala
/Users/novabyte/Desktop/bake/src/bake-test.vala.c:448:2: warning: 'g_type_init' is deprecated [-Wdeprecated-declarations]
        g_type_init ();
        ^
/usr/local/Cellar/glib/2.36.4/include/glib-2.0/gobject/gtype.h:669:23: note: 'g_type_init' declared here
void g_type_init (void);
                      ^
1 warning generated.
valac -o bake-bootstrap --pkg=glib-2.0 --pkg=gio-2.0 --pkg=posix --Xcc='-DGETTEXT_PACKAGE="C"' --Xcc='-DLIBRARY_DIRECTORY="/usr/lib"' src/bake.vala src/builder.vala src/config-bootstrap.vala src/fixes.vapi src/module-bzip.vala src/module-bzr.vala src/module-data.vala src/module-dpkg.vala src/module-gcc.vala src/module-gettext.vala src/module-gnome.vala src/module-ghc.vala src/module-git.vala src/module-gsettings.vala src/module-gtk.vala src/module-gzip.vala src/module-java.vala src/module-launchpad.vala src/module-mallard.vala src/module-man.vala src/module-mono.vala src/module-python.vala src/module-release.vala src/module-rpm.vala src/module-script.vala src/module-vala.vala src/module-xdg.vala src/module-xzip.vala src/pkg-config.vala src/recipe.vala src/rule.vala
/Users/novabyte/Desktop/bake/src/bake.vala.c:7579:2: warning: 'g_type_init' is deprecated [-Wdeprecated-declarations]
        g_type_init ();
        ^
/usr/local/Cellar/glib/2.36.4/include/glib-2.0/gobject/gtype.h:669:23: note: 'g_type_init' declared here
void g_type_init (void);
                      ^
1 warning generated.
/Users/novabyte/Desktop/bake/src/rule.vala.c:277:25: error: no member named 'st_mtim' in 'struct stat'
                                                _tmp12_ = _tmp11_.st_mtim;
                                                          ~~~~~~~ ^
/Users/novabyte/Desktop/bake/src/rule.vala.c:291:25: error: no member named 'st_mtim' in 'struct stat'
                                                _tmp17_ = _tmp16_.st_mtim;
                                                          ~~~~~~~ ^
/Users/novabyte/Desktop/bake/src/rule.vala.c:402:25: error: no member named 'st_mtim' in 'struct stat'
                                                _tmp50_ = _tmp49_.st_mtim;
                                                          ~~~~~~~ ^
/Users/novabyte/Desktop/bake/src/rule.vala.c:416:25: error: no member named 'st_mtim' in 'struct stat'
                                                _tmp55_ = _tmp54_.st_mtim;
                                                          ~~~~~~~ ^
4 errors generated.
error: cc exited with status 256
Compilation failed: 1 error(s), 0 warning(s)
make: *** [bake-bootstrap] Error 1
```

I'm building the codebase with Vala 0.20.1 on Mac OSX 10.8.4.

The best blog post I can find on the error message is:

http://www.mauvehaus.com/index.php/a-tale-of-two-stats/

Hope this helps.

Related branches

lp:~robert-ancell/bake/osx-stat

Robert Ancell (robert-ancell) on 2013-08-27

Changed in bake:
status:	New → Triaged
importance:	Undecided → Low
importance:	Low → Medium

Revision history for this message

Chris Molozian (chris-molozian) wrote on 2013-08-28:

Download full text (19.8 KiB)

Ok,

So I did a little more digging... I ran the build process with the compiler's `--ccode` flag to inspect the generated C code.

I inspected the output as follows:

```
$ ack -i st_mtim
src/fixes.vapi
5: public Posix.timespec st_mtim;

src/rule.c
277: _tmp12_ = _tmp11_.st_mtim;
291: _tmp17_ = _tmp16_.st_mtim;
402: _tmp50_ = _tmp49_.st_mtim;
416: _tmp55_ = _tmp54_.st_mtim;

src/rule.vala
42: if (Posix.S_ISREG (file_info.st_mode) && timespec_cmp (file_info.st_mtim, max_input_time) > 0)
44: max_input_time = file_info.st_mtim;
75: if (Posix.S_ISREG (file_info.st_mode) && timespec_cmp (file_info.st_mtim, max_output_time) > 0)
77: max_output_time = file_info.st_mtim;

tests/bake/touch.vala
40: times[1] = info.st_mtim;
```

It looks like you're making use of a field in the stat struct that does not exist in the "stat.h" on Darwin systems:

Ok,

So I did a little more digging... I ran the build process with the compiler's `--ccode` flag to inspect the generated C code.

I inspected the output as follows:

```
$ ack -i st_mtim
src/fixes.vapi
5:    public Posix.timespec st_mtim;

src/rule.c
277:						_tmp12_ = _tmp11_.st_mtim;
291:						_tmp17_ = _tmp16_.st_mtim;
402:						_tmp50_ = _tmp49_.st_mtim;
416:						_tmp55_ = _tmp54_.st_mtim;

src/rule.vala
42:                if (Posix.S_ISREG (file_info.st_mode) && timespec_cmp (file_info.st_mtim, max_input_time) > 0)
44:                    max_input_time = file_info.st_mtim;
75:                if (Posix.S_ISREG (file_info.st_mode) && timespec_cmp (file_info.st_mtim, max_output_time) > 0)
77:                    max_output_time = file_info.st_mtim;

tests/bake/touch.vala
40:                times[1] = info.st_mtim;
```

It looks like you're making use of a field in the stat struct that does not exist in the "stat.h" on Darwin systems:

```
$ cat /usr/include/sys/stat.h
/*
 * Copyright (c) 2000-2008 Apple Inc. All rights reserved.
 *
 * @APPLE_OSREFERENCE_LICENSE_HEADER_START@
 * 
 * This file contains Original Code and/or Modifications of Original Code
 * as defined in and that are subject to the Apple Public Source License
 * Version 2.0 (the 'License'). You may not use this file except in
 * compliance with the License. The rights granted to you under the License
 * may not be used to create, or enable the creation or redistribution of,
 * unlawful or unlicensed copies of an Apple operating system, or to
 * circumvent, violate, or enable the circumvention or violation of, any
 * terms of an Apple operating system software license agreement.
 * 
 * Please obtain a copy of the License at
 * http://www.opensource.apple.com/apsl/ and read it before using this file.
 * 
 * The Original Code and all software distributed under the License are
 * distributed on an 'AS IS' basis, WITHOUT WARRANTY OF ANY KIND, EITHER
 * EXPRESS OR IMPLIED, AND APPLE HEREBY DISCLAIMS ALL SUCH WARRANTIES,
 * INCLUDING WITHOUT LIMITATION, ANY WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE, QUIET ENJOYMENT OR NON-INFRINGEMENT.
 * Please see the License for the specific language governing rights and
 * limitations under the License.
 * 
 * @APPLE_OSREFERENCE_LICENSE_HEADER_END@
 */
/* Copyright (c) 1995 NeXT Computer, Inc. All Rights Reserved */
/*-
 * Copyright (c) 1982, 1986, 1989, 1993
 *	The Regents of the University of California.  All rights reserved.
 * (c) UNIX System Laboratories, Inc.
 * All or some portions of this file are derived from material licensed
 * to the University of California by American Telephone and Telegraph
 * Co. or Unix System Laboratories, Inc. and are reproduced herein with
 * the permission of UNIX System Laboratories, Inc.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 * 1. Redistributions of source code must retain the above copyright
 *    notice, this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright
 *    notice, this list of conditions and the following disclaimer in the
 *    documentation and/or other materials provided with the distribution.
 * 3. All advertising materials mentioning features or use of this software
 *    must display the following acknowledgement:
 *	This product includes software developed by the University of
 *	California, Berkeley and its contributors.
 * 4. Neither the name of the University nor the names of its contributors
 *    may be used to endorse or promote products derived from this software
 *    without specific prior written permission.
 *
 * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
 * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 * SUCH DAMAGE.
 *
 *	@(#)stat.h	8.9 (Berkeley) 8/17/94
 */

#ifndef _SYS_STAT_H_
#define	_SYS_STAT_H_

#include <sys/_types.h>
#include <sys/cdefs.h>
#include <Availability.h>

/* [XSI] The timespec structure may be defined as described in <time.h> */
#define __need_struct_timespec
#include <sys/_structs.h>

/*
 * [XSI] The blkcnt_t, blksize_t, dev_t, ino_t, mode_t, nlink_t, uid_t,
 * gid_t, off_t, and time_t types shall be defined as described in
 * <sys/types.h>.
 */
#ifndef _BLKCNT_T
typedef	__darwin_blkcnt_t	blkcnt_t;
#define	_BLKCNT_T
#endif

#ifndef _BLKSIZE_T
typedef	__darwin_blksize_t	blksize_t;
#define	_BLKSIZE_T
#endif

#ifndef _DEV_T
typedef	__darwin_dev_t		dev_t;		/* device number */
#define _DEV_T
#endif

#ifndef	_INO_T
typedef	__darwin_ino_t		ino_t;		/* inode number */
#define _INO_T
#endif

#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
#ifndef	_INO64_T
typedef	__darwin_ino64_t	ino64_t;	/* 64bit inode number */
#define _INO64_T
#endif
#endif /* !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE) */

#ifndef	_MODE_T
typedef	__darwin_mode_t		mode_t;
#define _MODE_T
#endif

#ifndef _NLINK_T
typedef	__uint16_t		nlink_t;	/* link count */
#define	_NLINK_T
#endif

#ifndef _UID_T
typedef __darwin_uid_t		uid_t;		/* user id */
#define _UID_T
#endif

#ifndef _GID_T
typedef __darwin_gid_t		gid_t;
#define _GID_T
#endif

#ifndef _OFF_T
typedef __darwin_off_t		off_t;
#define _OFF_T
#endif

#ifndef	_TIME_T
#define	_TIME_T
typedef	__darwin_time_t		time_t;
#endif

#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
/*
 * XXX So deprecated, it would make your head spin
 *
 * The old stat structure.  In fact, this is not used by the kernel at all,
 * and should not be used by user space, and should be removed from this
 * header file entirely (along with the unused cvtstat() prototype in
 * vnode_internal.h).
 */
struct ostat {
	__uint16_t	st_dev;		/* inode's device */
	ino_t		st_ino;		/* inode's number */
	mode_t		st_mode;	/* inode protection mode */
	nlink_t		st_nlink;	/* number of hard links */
	__uint16_t	st_uid;		/* user ID of the file's owner */
	__uint16_t	st_gid;		/* group ID of the file's group */
	__uint16_t	st_rdev;	/* device type */
	__int32_t	st_size;	/* file size, in bytes */
	struct	timespec st_atimespec;	/* time of last access */
	struct	timespec st_mtimespec;	/* time of last data modification */
	struct	timespec st_ctimespec;	/* time of last file status change */
	__int32_t	st_blksize;	/* optimal blocksize for I/O */
	__int32_t	st_blocks;	/* blocks allocated for file */
	__uint32_t	st_flags;	/* user defined flags for file */
	__uint32_t	st_gen;		/* file generation number */
};

#define __DARWIN_STRUCT_STAT64_TIMES \
	struct timespec st_atimespec;		/* time of last access */ \
	struct timespec st_mtimespec;		/* time of last data modification */ \
	struct timespec st_ctimespec;		/* time of last status change */ \
	struct timespec st_birthtimespec;	/* time of file creation(birth) */

#else /* (_POSIX_C_SOURCE && !_DARWIN_C_SOURCE) */

#define __DARWIN_STRUCT_STAT64_TIMES \
	time_t		st_atime;		/* [XSI] Time of last access */ \
	long		st_atimensec;		/* nsec of last access */ \
	time_t		st_mtime;		/* [XSI] Last data modification time */ \
	long		st_mtimensec;		/* last data modification nsec */ \
	time_t		st_ctime;		/* [XSI] Time of last status change */ \
	long		st_ctimensec;		/* nsec of last status change */ \
	time_t		st_birthtime;		/*  File creation time(birth)  */ \
	long		st_birthtimensec;	/* nsec of File creation time */

#endif /* (!_POSIX_C_SOURCE || _DARWIN_C_SOURCE) */

/*
 * This structure is used as the second parameter to the fstat64(),
 * lstat64(), and stat64() functions, and for struct stat when
 * __DARWIN_64_BIT_INO_T is set. __DARWIN_STRUCT_STAT64 is defined
 * above, depending on whether we use struct timespec or the direct
 * components.
 *
 * This is simillar to stat except for 64bit inode number
 * number instead of 32bit ino_t and the addition of create(birth) time.
 */
#define __DARWIN_STRUCT_STAT64 { \
	dev_t		st_dev;			/* [XSI] ID of device containing file */ \
	mode_t		st_mode;		/* [XSI] Mode of file (see below) */ \
	nlink_t		st_nlink;		/* [XSI] Number of hard links */ \
	__darwin_ino64_t st_ino;		/* [XSI] File serial number */ \
	uid_t		st_uid;			/* [XSI] User ID of the file */ \
	gid_t		st_gid;			/* [XSI] Group ID of the file */ \
	dev_t		st_rdev;		/* [XSI] Device ID */ \
	__DARWIN_STRUCT_STAT64_TIMES \
	off_t		st_size;		/* [XSI] file size, in bytes */ \
	blkcnt_t	st_blocks;		/* [XSI] blocks allocated for file */ \
	blksize_t	st_blksize;		/* [XSI] optimal blocksize for I/O */ \
	__uint32_t	st_flags;		/* user defined flags for file */ \
	__uint32_t	st_gen;			/* file generation number */ \
	__int32_t	st_lspare;		/* RESERVED: DO NOT USE! */ \
	__int64_t	st_qspare[2];		/* RESERVED: DO NOT USE! */ \
}

/*
 * [XSI] This structure is used as the second parameter to the fstat(),
 * lstat(), and stat() functions.
 */
#if __DARWIN_64_BIT_INO_T

struct stat __DARWIN_STRUCT_STAT64;

#else /* !__DARWIN_64_BIT_INO_T */

struct stat {
	dev_t	 	st_dev;		/* [XSI] ID of device containing file */
	ino_t	  	st_ino;		/* [XSI] File serial number */
	mode_t	 	st_mode;	/* [XSI] Mode of file (see below) */
	nlink_t		st_nlink;	/* [XSI] Number of hard links */
	uid_t		st_uid;		/* [XSI] User ID of the file */
	gid_t		st_gid;		/* [XSI] Group ID of the file */
	dev_t		st_rdev;	/* [XSI] Device ID */
#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
	struct	timespec st_atimespec;	/* time of last access */
	struct	timespec st_mtimespec;	/* time of last data modification */
	struct	timespec st_ctimespec;	/* time of last status change */
#else
	time_t		st_atime;	/* [XSI] Time of last access */
	long		st_atimensec;	/* nsec of last access */
	time_t		st_mtime;	/* [XSI] Last data modification time */
	long		st_mtimensec;	/* last data modification nsec */
	time_t		st_ctime;	/* [XSI] Time of last status change */
	long		st_ctimensec;	/* nsec of last status change */
#endif
	off_t		st_size;	/* [XSI] file size, in bytes */
	blkcnt_t	st_blocks;	/* [XSI] blocks allocated for file */
	blksize_t	st_blksize;	/* [XSI] optimal blocksize for I/O */
	__uint32_t	st_flags;	/* user defined flags for file */
	__uint32_t	st_gen;		/* file generation number */
	__int32_t	st_lspare;	/* RESERVED: DO NOT USE! */
	__int64_t	st_qspare[2];	/* RESERVED: DO NOT USE! */
};

#endif /* __DARWIN_64_BIT_INO_T */

#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)

#if !__DARWIN_ONLY_64_BIT_INO_T

struct stat64 __DARWIN_STRUCT_STAT64;

#endif /* !__DARWIN_ONLY_64_BIT_INO_T */

#endif /* (!_POSIX_C_SOURCE || _DARWIN_C_SOURCE) */

#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
#define st_atime st_atimespec.tv_sec
#define st_mtime st_mtimespec.tv_sec
#define st_ctime st_ctimespec.tv_sec
#define st_birthtime st_birthtimespec.tv_sec
#endif /* (!_POSIX_C_SOURCE || _DARWIN_C_SOURCE) */

/*
 * [XSI] The following are symbolic names for the values of type mode_t.  They
 * are bitmap values.
 */
#ifndef S_IFMT
/* File type */
#define	S_IFMT		0170000		/* [XSI] type of file mask */
#define	S_IFIFO		0010000		/* [XSI] named pipe (fifo) */
#define	S_IFCHR		0020000		/* [XSI] character special */
#define	S_IFDIR		0040000		/* [XSI] directory */
#define	S_IFBLK		0060000		/* [XSI] block special */
#define	S_IFREG		0100000		/* [XSI] regular */
#define	S_IFLNK		0120000		/* [XSI] symbolic link */
#define	S_IFSOCK	0140000		/* [XSI] socket */
#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
#define	S_IFWHT		0160000		/* OBSOLETE: whiteout */
#endif

/* File mode */
/* Read, write, execute/search by owner */
#define	S_IRWXU		0000700		/* [XSI] RWX mask for owner */
#define	S_IRUSR		0000400		/* [XSI] R for owner */
#define	S_IWUSR		0000200		/* [XSI] W for owner */
#define	S_IXUSR		0000100		/* [XSI] X for owner */
/* Read, write, execute/search by group */
#define	S_IRWXG		0000070		/* [XSI] RWX mask for group */
#define	S_IRGRP		0000040		/* [XSI] R for group */
#define	S_IWGRP		0000020		/* [XSI] W for group */
#define	S_IXGRP		0000010		/* [XSI] X for group */
/* Read, write, execute/search by others */
#define	S_IRWXO		0000007		/* [XSI] RWX mask for other */
#define	S_IROTH		0000004		/* [XSI] R for other */
#define	S_IWOTH		0000002		/* [XSI] W for other */
#define	S_IXOTH		0000001		/* [XSI] X for other */

#define	S_ISUID		0004000		/* [XSI] set user id on execution */
#define	S_ISGID		0002000		/* [XSI] set group id on execution */
#define	S_ISVTX		0001000		/* [XSI] directory restrcted delete */

#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
#define	S_ISTXT		S_ISVTX		/* sticky bit: not supported */
#define	S_IREAD		S_IRUSR		/* backward compatability */
#define	S_IWRITE	S_IWUSR		/* backward compatability */
#define	S_IEXEC		S_IXUSR		/* backward compatability */
#endif
#endif	/* !S_IFMT */

/*
 * [XSI] The following macros shall be provided to test whether a file is
 * of the specified type.  The value m supplied to the macros is the value
 * of st_mode from a stat structure.  The macro shall evaluate to a non-zero
 * value if the test is true; 0 if the test is false.
 */
#define	S_ISBLK(m)	(((m) & S_IFMT) == S_IFBLK)	/* block special */
#define	S_ISCHR(m)	(((m) & S_IFMT) == S_IFCHR)	/* char special */
#define	S_ISDIR(m)	(((m) & S_IFMT) == S_IFDIR)	/* directory */
#define	S_ISFIFO(m)	(((m) & S_IFMT) == S_IFIFO)	/* fifo or socket */
#define	S_ISREG(m)	(((m) & S_IFMT) == S_IFREG)	/* regular file */
#define	S_ISLNK(m)	(((m) & S_IFMT) == S_IFLNK)	/* symbolic link */
#define	S_ISSOCK(m)	(((m) & S_IFMT) == S_IFSOCK)	/* socket */
#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
#define	S_ISWHT(m)	(((m) & S_IFMT) == S_IFWHT)	/* OBSOLETE: whiteout */
#endif

/*
 * [XSI] The implementation may implement message queues, semaphores, or
 * shared memory objects as distinct file types.  The following macros
 * shall be provided to test whether a file is of the specified type.
 * The value of the buf argument supplied to the macros is a pointer to
 * a stat structure.  The macro shall evaluate to a non-zero value if
 * the specified object is implemented as a distinct file type and the
 * specified file type is contained in the stat structure referenced by
 * buf.  Otherwise, the macro shall evaluate to zero.
 *
 * NOTE:	The current implementation does not do this, although
 *		this may change in future revisions, and co currently only
 *		provides these macros to ensure source compatability with
 *		implementations which do.
 */
#define	S_TYPEISMQ(buf)		(0)	/* Test for a message queue */
#define	S_TYPEISSEM(buf)	(0)	/* Test for a semaphore */
#define	S_TYPEISSHM(buf)	(0)	/* Test for a shared memory object */

/*
 * [TYM] The implementation may implement typed memory objects as distinct
 * file types, and the following macro shall test whether a file is of the
 * specified type.  The value of the buf argument supplied to the macros is
 * a pointer to a stat structure.  The macro shall evaluate to a non-zero
 * value if the specified object is implemented as a distinct file type and
 * the specified file type is contained in the stat structure referenced by
 * buf.  Otherwise, the macro shall evaluate to zero.
 *
 * NOTE:	The current implementation does not do this, although
 *		this may change in future revisions, and co currently only
 *		provides this macro to ensure source compatability with
 *		implementations which do.
 */
#define	S_TYPEISTMO(buf)	(0)	/* Test for a typed memory object */

#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
#define	ACCESSPERMS	(S_IRWXU|S_IRWXG|S_IRWXO)	/* 0777 */
							/* 7777 */
#define	ALLPERMS	(S_ISUID|S_ISGID|S_ISTXT|S_IRWXU|S_IRWXG|S_IRWXO)
							/* 0666 */
#define	DEFFILEMODE	(S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH|S_IWOTH)

#define S_BLKSIZE	512		/* block size used in the stat struct */

/*
 * Definitions of flags stored in file flags word.
 *
 * Super-user and owner changeable flags.
 */
#define	UF_SETTABLE	0x0000ffff	/* mask of owner changeable flags */
#define	UF_NODUMP	0x00000001	/* do not dump file */
#define	UF_IMMUTABLE	0x00000002	/* file may not be changed */
#define	UF_APPEND	0x00000004	/* writes to file may only append */
#define UF_OPAQUE	0x00000008	/* directory is opaque wrt. union */
/*
 * The following bit is reserved for FreeBSD.  It is not implemented
 * in Mac OS X.
 */
/* #define UF_NOUNLINK	0x00000010 */	/* file may not be removed or renamed */
#define UF_COMPRESSED	0x00000020	/* file is hfs-compressed */
#define UF_TRACKED		0x00000040	/* file renames and deletes are tracked */
/* Bits 0x0080 through 0x4000 are currently undefined. */
#define UF_HIDDEN	0x00008000	/* hint that this item should not be */
					/* displayed in a GUI */
/*
 * Super-user changeable flags.
 */
#define	SF_SETTABLE	0xffff0000	/* mask of superuser changeable flags */
#define	SF_ARCHIVED	0x00010000	/* file is archived */
#define	SF_IMMUTABLE	0x00020000	/* file may not be changed */
#define	SF_APPEND	0x00040000	/* writes to file may only append */

/*
 * The following two bits are reserved for FreeBSD.  They are not
 * implemented in Mac OS X.
 */
/* #define SF_NOUNLINK	0x00100000 */	/* file may not be removed or renamed */
/* #define SF_SNAPSHOT	0x00200000 */	/* snapshot inode */
/* NOTE: There is no SF_HIDDEN bit. */

#endif

__BEGIN_DECLS
/* [XSI] */
int	chmod(const char *, mode_t) __DARWIN_ALIAS(chmod);
int	fchmod(int, mode_t) __DARWIN_ALIAS(fchmod);
int	fstat(int, struct stat *) __DARWIN_INODE64(fstat);
int	lstat(const char *, struct stat *) __DARWIN_INODE64(lstat);
int	mkdir(const char *, mode_t);
int	mkfifo(const char *, mode_t);
int	stat(const char *, struct stat *) __DARWIN_INODE64(stat);
int	mknod(const char *, mode_t, dev_t);
mode_t	umask(mode_t);

#if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
#ifndef _FILESEC_T
struct _filesec;
typedef struct _filesec	*filesec_t;
#define _FILESEC_T
#endif
int	chflags(const char *, __uint32_t);
int	chmodx_np(const char *, filesec_t);
int	fchflags(int, __uint32_t);
int	fchmodx_np(int, filesec_t);
int	fstatx_np(int, struct stat *, filesec_t) __DARWIN_INODE64(fstatx_np);
int	lchflags(const char *, __uint32_t) __OSX_AVAILABLE_STARTING(__MAC_10_5, __IPHONE_2_0);
int	lchmod(const char *, mode_t) __OSX_AVAILABLE_STARTING(__MAC_10_5, __IPHONE_2_0);
int	lstatx_np(const char *, struct stat *, filesec_t) __DARWIN_INODE64(lstatx_np);
int	mkdirx_np(const char *, filesec_t);
int	mkfifox_np(const char *, filesec_t);
int	statx_np(const char *, struct stat *, filesec_t) __DARWIN_INODE64(statx_np);
int	umaskx_np(filesec_t) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_4,__MAC_10_6,__IPHONE_NA,__IPHONE_NA);

#if !__DARWIN_ONLY_64_BIT_INO_T
/* The following deprecated routines are simillar to stat and friends except provide struct stat64 instead of struct stat  */
int	fstatx64_np(int, struct stat64 *, filesec_t) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_5,__MAC_10_6,__IPHONE_NA,__IPHONE_NA);
int	lstatx64_np(const char *, struct stat64 *, filesec_t) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_5,__MAC_10_6,__IPHONE_NA,__IPHONE_NA);
int	statx64_np(const char *, struct stat64 *, filesec_t) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_5,__MAC_10_6,__IPHONE_NA,__IPHONE_NA);
int	fstat64(int, struct stat64 *) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_5,__MAC_10_6,__IPHONE_NA,__IPHONE_NA);
int	lstat64(const char *, struct stat64 *) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_5,__MAC_10_6,__IPHONE_NA,__IPHONE_NA);
int	stat64(const char *, struct stat64 *) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_5,__MAC_10_6,__IPHONE_NA,__IPHONE_NA);
#endif /* !__DARWIN_ONLY_64_BIT_INO_T */
#endif /* (!_POSIX_C_SOURCE || _DARWIN_C_SOURCE) */

__END_DECLS
#endif /* !_SYS_STAT_H_ */
```

Hope this adds a bit more detail. I'm not sure what the best workaround is...

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2013-09-04:

Hi Chris,

Thanks for the diagnosis!

Could you try lp:~robert-ancell/bake/osx-stat and see if that works for you?

Revision history for this message

Chris Molozian (chris-molozian) wrote on 2013-09-04:

Download full text (10.0 KiB)

Hi Robert,

Good morning :)

I cloned and attempted to build the branch. Initially my results were:

```
$ make
valac -o bake-template --pkg=posix src/bake-template.vala
/Users/novabyte/Desktop/osx-stat/src/bake-template.vala.c:477:2: warning: 'g_type_init' is deprecated [-Wdeprecated-declarations]
        g_type_init ();
        ^
/usr/local/Cellar/glib/2.36.4/include/glib-2.0/gobject/gtype.h:669:23: note: 'g_type_init' declared here
void g_type_init (void);
                      ^
1 warning generated.
valac -o bake-test --pkg=posix src/bake-test.vala
/Users/novabyte/Desktop/osx-stat/src/bake-test.vala.c:448:2: warning: 'g_type_init' is deprecated [-Wdeprecated-declarations]
        g_type_init ();
        ^
/usr/local/Cellar/glib/2.36.4/include/glib-2.0/gobject/gtype.h:669:23: note: 'g_type_init' declared here
void g_type_init (void);
                      ^
1 warning generated.
valac -o bake-bootstrap --pkg=glib-2.0 --pkg=gio-2.0 --pkg=posix --Xcc='-DGETTEXT_PACKAGE="C"' --Xcc='-DLIBRARY_DIRECTORY="/usr/lib"' src/bake.vala src/builder.vala src/config-bootstrap.vala src/fixes.vapi src/module-bzip.vala src/module-bzr.vala src/module-data.vala src/module-dpkg.vala src/module-gcc.vala src/module-gettext.vala src/module-gnome.vala src/module-ghc.vala src/module-git.vala src/module-gsettings.vala src/module-gtk.vala src/module-gzip.vala src/module-java.vala src/module-launchpad.vala src/module-mallard.vala src/module-man.vala src/module-mono.vala src/module-python.vala src/module-release.vala src/module-rpm.vala src/module-script.vala src/module-vala.vala src/module-xdg.vala src/module-xzip.vala src/pkg-config.vala src/recipe.vala src/rule.vala
/Users/novabyte/Desktop/osx-stat/src/bake.vala.c:7579:2: warning: 'g_type_init' is deprecated [-Wdeprecated-declarations]
        g_type_init ();
        ^
/usr/local/Cellar/glib/2.36.4/include/glib-2.0/gobject/gtype.h:669:23: note: 'g_type_init' declared here
void g_type_init (void);
                      ^
1 warning generated.
/Users/novabyte/Desktop/osx-stat/src/rule.vala.c:272:6: warning: implicit declaration of function 'stat_get_modification_time' is invalid in C99 [-Wimplicit-function-declaration]
                                        stat_get_modification_time (&_tmp7_, &_tmp8_);
                                        ^
1 warning generated.
Undefined symbols for architecture x86_64:
  "_stat_get_modification_time", referenced from:
      _rule_needs_build in rule-uvTG7Q.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
error: cc exited with status 256
Compilation failed: 1 error(s), 0 warning(s)
make: *** [bake-bootstrap] Error 1
```

I had a look at your changes in the branch and modified the `Makefile` to also include `fixes.c` in it's `SOURCES` list. I'm not sure if this is exactly the right place to make the change but it allowed the Vala compiler to find the new C source file when building `bake-bootstrap`. I cleaned the buildspace and rebuilt the codebase as follows:

```
$ make
valac -o bake-bootstrap -...

Hi Robert,

Good morning :)

I cloned and attempted to build the branch. Initially my results were:

```
$ make
valac -o bake-template --pkg=posix src/bake-template.vala
/Users/novabyte/Desktop/osx-stat/src/bake-template.vala.c:477:2: warning: 'g_type_init' is deprecated [-Wdeprecated-declarations]
        g_type_init ();
        ^
/usr/local/Cellar/glib/2.36.4/include/glib-2.0/gobject/gtype.h:669:23: note: 'g_type_init' declared here
void                  g_type_init                    (void);
                      ^
1 warning generated.
valac -o bake-test --pkg=posix src/bake-test.vala
/Users/novabyte/Desktop/osx-stat/src/bake-test.vala.c:448:2: warning: 'g_type_init' is deprecated [-Wdeprecated-declarations]
        g_type_init ();
        ^
/usr/local/Cellar/glib/2.36.4/include/glib-2.0/gobject/gtype.h:669:23: note: 'g_type_init' declared here
void                  g_type_init                    (void);
                      ^
1 warning generated.
valac -o bake-bootstrap --pkg=glib-2.0 --pkg=gio-2.0 --pkg=posix --Xcc='-DGETTEXT_PACKAGE="C"' --Xcc='-DLIBRARY_DIRECTORY="/usr/lib"' src/bake.vala src/builder.vala src/config-bootstrap.vala src/fixes.vapi src/module-bzip.vala src/module-bzr.vala src/module-data.vala src/module-dpkg.vala src/module-gcc.vala src/module-gettext.vala src/module-gnome.vala src/module-ghc.vala src/module-git.vala src/module-gsettings.vala src/module-gtk.vala src/module-gzip.vala src/module-java.vala src/module-launchpad.vala src/module-mallard.vala src/module-man.vala src/module-mono.vala src/module-python.vala src/module-release.vala src/module-rpm.vala src/module-script.vala src/module-vala.vala src/module-xdg.vala src/module-xzip.vala src/pkg-config.vala src/recipe.vala src/rule.vala
/Users/novabyte/Desktop/osx-stat/src/bake.vala.c:7579:2: warning: 'g_type_init' is deprecated [-Wdeprecated-declarations]
        g_type_init ();
        ^
/usr/local/Cellar/glib/2.36.4/include/glib-2.0/gobject/gtype.h:669:23: note: 'g_type_init' declared here
void                  g_type_init                    (void);
                      ^
1 warning generated.
/Users/novabyte/Desktop/osx-stat/src/rule.vala.c:272:6: warning: implicit declaration of function 'stat_get_modification_time' is invalid in C99 [-Wimplicit-function-declaration]
                                        stat_get_modification_time (&_tmp7_, &_tmp8_);
                                        ^
1 warning generated.
Undefined symbols for architecture x86_64:
  "_stat_get_modification_time", referenced from:
      _rule_needs_build in rule-uvTG7Q.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
error: cc exited with status 256
Compilation failed: 1 error(s), 0 warning(s)
make: *** [bake-bootstrap] Error 1
```

```
$ make
valac -o bake-bootstrap --pkg=glib-2.0 --pkg=gio-2.0 --pkg=posix --Xcc='-DGETTEXT_PACKAGE="C"' --Xcc='-DLIBRARY_DIRECTORY="/usr/lib"' src/bake.vala src/builder.vala src/config-bootstrap.vala src/fixes.vapi src/module-bzip.vala src/module-bzr.vala src/module-data.vala src/module-dpkg.vala src/module-gcc.vala src/module-gettext.vala src/module-gnome.vala src/module-ghc.vala src/module-git.vala src/module-gsettings.vala src/module-gtk.vala src/module-gzip.vala src/module-java.vala src/module-launchpad.vala src/module-mallard.vala src/module-man.vala src/module-mono.vala src/module-python.vala src/module-release.vala src/module-rpm.vala src/module-script.vala src/module-vala.vala src/module-xdg.vala src/module-xzip.vala src/pkg-config.vala src/recipe.vala src/rule.vala src/fixes.c
/Users/novabyte/Desktop/osx-stat/src/bake.vala.c:7579:2: warning: 'g_type_init' is deprecated [-Wdeprecated-declarations]
        g_type_init ();
        ^
/usr/local/Cellar/glib/2.36.4/include/glib-2.0/gobject/gtype.h:669:23: note: 'g_type_init' declared here
void                  g_type_init                    (void);
                      ^
1 warning generated.
/Users/novabyte/Desktop/osx-stat/src/rule.vala.c:272:6: warning: implicit declaration of function 'stat_get_modification_time' is invalid in C99 [-Wimplicit-function-declaration]
                                        stat_get_modification_time (&_tmp7_, &_tmp8_);
                                        ^
1 warning generated.
PATH=`pwd`:$PATH ./bake-bootstrap --configure library-directory=/usr/lib
[Configuring]
  install-directory        - / (default)
  system-config-directory  - /etc (default)
  system-binary-directory  - /sbin (default)
  system-library-directory - /lib (default)
  resource-directory       - /usr (default)
  binary-directory         - $(options.resource-directory)/bin (default)
  library-directory        - /usr/lib
  data-directory           - $(options.resource-directory)/share (default)
  include-directory        - $(options.resource-directory)/include (default)
  project-data-directory   - $(options.data-directory)/bake (default)
[Configure complete]
PATH=`pwd`:$PATH ./bake-bootstrap
[Entering directory src]
TEMPLATE config.vala
VALAC bake-template.vala
GCC bake-template.vala
GCC-LINK bake-template
VALAC bake-gettext.vala
GCC bake-gettext.vala
GCC-LINK bake-gettext
VALAC bake-test.vala
GCC bake-test.vala
GCC-LINK bake-test
VALAC-FAST-VAPI builder.vala
VALAC-FAST-VAPI config.vala
VALAC-FAST-VAPI module-bzip.vala
VALAC-FAST-VAPI module-bzr.vala
VALAC-FAST-VAPI module-data.vala
VALAC-FAST-VAPI module-dpkg.vala
VALAC-FAST-VAPI module-gcc.vala
VALAC-FAST-VAPI module-gettext.vala
VALAC-FAST-VAPI module-ghc.vala
VALAC-FAST-VAPI module-git.vala
VALAC-FAST-VAPI module-gnome.vala
VALAC-FAST-VAPI module-gsettings.vala
VALAC-FAST-VAPI module-gtk.vala
VALAC-FAST-VAPI module-gzip.vala
VALAC-FAST-VAPI module-java.vala
VALAC-FAST-VAPI module-launchpad.vala
VALAC-FAST-VAPI module-mallard.vala
VALAC-FAST-VAPI module-man.vala
VALAC-FAST-VAPI module-mono.vala
VALAC-FAST-VAPI module-python.vala
VALAC-FAST-VAPI module-release.vala
VALAC-FAST-VAPI module-rpm.vala
VALAC-FAST-VAPI module-script.vala
VALAC-FAST-VAPI module-vala.vala
VALAC-FAST-VAPI module-xdg.vala
VALAC-FAST-VAPI module-xzip.vala
VALAC-FAST-VAPI pkg-config.vala
VALAC-FAST-VAPI recipe.vala
VALAC-FAST-VAPI rule.vala
VALAC bake.vala
GCC bake.vala
VALAC-FAST-VAPI bake.vala
VALAC builder.vala
GCC builder.vala
VALAC config.vala
GCC config.vala
GCC fixes.c
VALAC module-bzip.vala
GCC module-bzip.vala
VALAC module-bzr.vala
GCC module-bzr.vala
VALAC module-data.vala
GCC module-data.vala
VALAC module-dpkg.vala
GCC module-dpkg.vala
VALAC module-gcc.vala
GCC module-gcc.vala
VALAC module-gettext.vala
GCC module-gettext.vala
VALAC module-ghc.vala
GCC module-ghc.vala
VALAC module-git.vala
GCC module-git.vala
VALAC module-gnome.vala
GCC module-gnome.vala
VALAC module-gsettings.vala
GCC module-gsettings.vala
VALAC module-gtk.vala
GCC module-gtk.vala
VALAC module-gzip.vala
GCC module-gzip.vala
VALAC module-java.vala
GCC module-java.vala
VALAC module-launchpad.vala
GCC module-launchpad.vala
VALAC module-mallard.vala
GCC module-mallard.vala
VALAC module-man.vala
GCC module-man.vala
VALAC module-mono.vala
GCC module-mono.vala
VALAC module-python.vala
GCC module-python.vala
VALAC module-release.vala
GCC module-release.vala
VALAC module-rpm.vala
GCC module-rpm.vala
VALAC module-script.vala
GCC module-script.vala
VALAC module-vala.vala
GCC module-vala.vala
VALAC module-xdg.vala
GCC module-xdg.vala
VALAC module-xzip.vala
GCC module-xzip.vala
VALAC pkg-config.vala
GCC pkg-config.vala
VALAC recipe.vala
GCC recipe.vala
VALAC rule.vala
GCC rule.vala
GCC-LINK bake
[Entering directory tests/bake]
VALAC-FAST-VAPI status.vala
VALAC touch.vala
GCC touch.vala
gcc -w  -I/usr/local/Cellar/glib/2.36.4/include/glib-2.0 -I/usr/local/Cellar/glib/2.36.4/lib/glib-2.0/include -I/usr/local/opt/gettext/include -D_REENTRANT -I/usr/local/Cellar/glib/2.36.4/include/gio-unix-2.0/ -c .built/touch-touch.c -o .built/touch-touch.o
.built/touch-touch.c: In function ‘touch_main’:
.built/touch-touch.c:333: error: ‘struct stat’ has no member named ‘st_atim’
.built/touch-touch.c:337: error: ‘struct stat’ has no member named ‘st_mtim’
.built/touch-touch.c:346: error: ‘UTIME_NOW’ undeclared (first use in this function)
.built/touch-touch.c:346: error: (Each undeclared identifier is reported only once
.built/touch-touch.c:346: error: for each function it appears in.)
Command exited with return value 1
[Build failed]
make: *** [all] Error 1
```

It looks like Bake is now successfully built but the `tests/bake/touch.vala` test case has a few problems with the new workaround for OS X. I wasn't sure how to fix this, my Vala foo is pretty weak right now.

Nevertheless Bake is built successfully:

```
$ ./src/bake --version
bake 0.1.32+bzr

$ ./src/bake --help
Usage:
  bake [OPTION?] [TARGET] - Build system

Help Options:
  -h, --help         Show help options

Application Options:
  --list-options     List project options
  --configure        Configure build options
  --unconfigure      Clear configuration
  --parallel         Run commands in parallel
  --expand           Expand current recipe and print to stdout
  -v, --version      Show release version
  --verbose          Show verbose output
  --color=WHEN       Colorize output. WHEN is 'always', 'never' or 'auto' (default)
  -d, --debug        Print debugging messages

$ otool -L src/bake
src/bake:
	/usr/local/lib/libgio-2.0.0.dylib (compatibility version 3601.0.0, current version 3601.4.0)
	/usr/local/lib/libglib-2.0.0.dylib (compatibility version 3601.0.0, current version 3601.4.0)
	/usr/local/opt/gettext/lib/libintl.8.dylib (compatibility version 10.0.0, current version 10.2.0)
	/usr/local/lib/libgobject-2.0.0.dylib (compatibility version 3601.0.0, current version 3601.4.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 169.3.0)
```

Hope this helps.

PS: I wish that Launchpad had some sort of Markdown support in bug report comments...

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2013-09-06:

Thanks, I've incorporated your changes into lp:~robert-ancell/bake/osx-stat and fixed touch to build with the same fix.

However, the last bit I can't work out is where/if UTIME_NOW is defined on OSX. Could you see if you can find what header it is in? Also please look in the apple man page for futimens - that's the function that requires it.

Revision history for this message

Chris Molozian (chris-molozian) wrote on 2013-09-06:

Hi Robert,

It appears that `futimens(...)` doesn't exist on OS X. It's a POSIX standard, but BSD systems have `futimes(...)` instead.

The best source of information I could find on this is from an old LLVM bug report:

http://llvm.org/bugs/show_bug.cgi?id=16442

There's also a bunch of patches, the most relevant I could find for you is:

http://comments.gmane.org/gmane.comp.compilers.llvm.cvs/150748

The OSX manpage for `futimes(...)` is available here:

https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man2/futimes.2.html

Hope this helps. =)

Revision history for this message

Chris Molozian (chris-molozian) wrote on 2013-09-14:

Hey Robert,

Is there anything more I can do to help with this?

Cheers,

Chris

Revision history for this message

Robert Ancell (robert-ancell) wrote on 2013-09-16:

Hi, sorry, haven't had the time to investigate more.

If you are able to branch and modify lp:~robert-ancell/bake/osx-stat so it compiles on OSX I think we're good to land. The last blocker is the use of futimens, I'm not sure if we strictly need this - it's only used in the mock for "touch". So we may be able to get it to work with just futimes(). Please try and see - just check that the tests work by running "bake test".

Thanks for your help!

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

llvm #16442
[RESOLVED FIXED] Edit

Bug watches keep track of this bug in other bug trackers.