[2.4 RC1] Category selector presented without submit button

Bug #194849 reported by Foppe Hemminga on 2008-02-23
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
b2evolution
Medium
Tilman Blumenbach

Bug Description

This bug lived all the way from 1.6 through 2.4.
First appearance: http://forums.b2evolution.net/viewtopic.php?t=9750
Second appearance: http://forums.b2evolution.net/...hp?t=14539

Description:
It is possible to select multiple categories for view. In the 1.x.x system it needed an extra line in the skin, in 2.4 it is a setting in the Categories widget. It generates selection boxes before the categories and radiobuttons for ANY ANY BUT and ALL selection. What is omittesd is the start of the <form> tag and the submit button plus the closing </form> tag.

Solution :
For both the 1.10 series as the 2.4 series I made a hack which consists of this code before the category list:

/blog/inc/widgets/widgets/_coll_category_list.widget.php

PHP:
        // start First part of Add Missing SubmitButton hack by Afwas
        if( $this->disp_params['use_form'] )
        { // We want to add form fields:
            $bblogUrl = $Blog->dget( 'blogurl', 'raw' );
            echo'<form action="'.$bblogUrl.'" method="get">';
        }
        // end first part of hack

and this codepiece after the category list:
PHP:
            <!-- Second part of Add Missing SubmitButton hack by Afwas -->
              <br /><br />
              <input name="submit" class="submit" value="Get selection" type="submit">
              </form>
            <!-- End hack by Afwas -->

(This is taken from the 2.4 version, In 1.10 the $param is called 'list' and the global $Blog variable must be included.)

Also reported at http://forums.b2evolution.net/viewtopic.php?t=14544

Foppe Hemminga (foppe) wrote :
Foppe Hemminga (foppe) wrote :

After a bug report from this hack I have a new proposed version for the 2.4 series only. Replace the first snippet by:
        // start First part of Add Missing SubmitButton hack by Afwas
        if( $this->disp_params['use_form'] )
        { // We want to add form fields:
            $bblogUrl = $Blog->gen_blogurl();
            echo'<form action="'.$bblogUrl.'" method="post">';

        }
        // end first part of hack

Foppe Hemminga (foppe) on 2008-03-08
Changed in b2evolution:
importance: Undecided → Medium
Tilman Blumenbach (tblue) wrote :

Fixed in branches HEAD and v-2-4.

Changed in b2evolution:
assignee: nobody → tblue
status: New → Fix Committed
Tilman Blumenbach (tblue) wrote :

Fix has been reverted in CVS because of problems (rev1.17 in HEAD, rev1.9.2.2 in v-2-4).

Changed in b2evolution:
assignee: tblue → nobody
status: Fix Committed → Triaged
Tilman Blumenbach (tblue) wrote :

Fixed in HEAD (again).

Changed in b2evolution:
assignee: nobody → tblue
status: Triaged → Fix Committed
Daniel Hahler (blueyed) wrote :

Closing as Fix Released, assuming that it has been released since then..

Thanks.

Changed in b2evolution:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers