Port the keyboard indicator in gsd to use the app. indicator protocol

Bug #599844 reported by David Barth on 2010-06-29
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Undecided
Unassigned
Ayatana Ubuntu
Medium
Karl Lattimer
gnome-settings-daemon (Ubuntu)
Low
Karl Lattimer

Bug Description

Work item to track the port of gnome-settings-daemon keyboard status icon to use the new app. indicator API.

David Barth (dbarth) wrote :

Putting that on the a3 radar

Changed in ayatana-ubuntu:
milestone: none → maverick-alpha-3
David Barth (dbarth) wrote :

Passing on to jcastro for when the app. indicator icon to code is defined. Marking incomplete as such
mpt: what do you advise we put on the indicator?

Changed in ayatana-ubuntu:
assignee: nobody → Jorge O. Castro (jorge)
status: New → Incomplete
Jorge Castro (jorge) wrote :

Bug #564034 has information on how we fix this in ibus that might be relevant.

Changed in ayatana-ubuntu:
assignee: Jorge O. Castro (jorge) → nobody
Jorge Castro (jorge) wrote :

David, I don't have permission to assign this bug, can you please assign it to Karl Lattimer, launchpad id is: karl-qdh

David Barth (dbarth) on 2010-07-29
Changed in ayatana-ubuntu:
assignee: nobody → Karl Lattimer (karl-qdh)
milestone: maverick-alpha-3 → none
importance: Undecided → Medium
milestone: none → ubuntu-10.10-beta
Sebastien Bacher (seb128) wrote :

there has been work done on that previous cycle, see bug #497875, the patch was working but got blocked due to the lack of label support in appindicator and the fact that users want the layout to be indicated on screen

Sebastien Bacher (seb128) wrote :

see bug #531173 about the issue

Karl Lattimer (karl-qdh) on 2010-08-05
Changed in ayatana-ubuntu:
status: Incomplete → In Progress
Karl Lattimer (karl-qdh) wrote :

This is an updated version of Jan Arne Petersen's patch in https://bugs.edge.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/497875

This is just a straight update so it applies to the 2.30.2 tarball directly, I still need to merge the patch with the other indicator patch and make it use a label for the indicator.

Karl Lattimer (karl-qdh) wrote :

Updated the patch of gnome-settings-daemon to include both the existing xrandr indicator and the patch supplied with https://bugs.edge.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/497875

All that needs to be done now is updating it to use a label rather than a non-descriptive icon

Karl Lattimer (karl-qdh) wrote :

I have a partially working patch now.

The correct labels are set however they are not correctly set on startup, so I will endeavour to fix that issue and then upload the updated patch.

Karl Lattimer (karl-qdh) wrote :

This is an incomplete but working patch, currently likely to leak memory.

The deallocation causes a segfault, will discuss this problem with tedg later today.

Karl Lattimer (karl-qdh) on 2010-08-11
Changed in ayatana-ubuntu:
assignee: Karl Lattimer (karl-qdh) → nobody
assignee: nobody → Karl Lattimer (karl-qdh)
Karl Lattimer (karl-qdh) wrote :

Allowing any of the free's or g_object_unrefs will cause a crash.. which is pretty weird

Desperately need to figure out a way to debug this, get some text to print into a terminal and run a valgrind many difficulties related to debugging gnome-settings-daemon.

Karl Lattimer (karl-qdh) wrote :

As seb128/davidbarth agreed to release this patch in a leaking form a follow up bug has been created for the probable leaking;

https://bugs.launchpad.net/ayatana-ubuntu/+bug/616765

David Barth (dbarth) wrote :

re-assigning to seb128 so that this can go in for today's upload window

Changed in ayatana-ubuntu:
assignee: Karl Lattimer (karl-qdh) → Canonical Desktop Team (canonical-desktop-team)
Changed in ayatana-ubuntu:
assignee: Canonical Desktop Team (canonical-desktop-team) → nobody
Changed in gnome-settings-daemon (Ubuntu):
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Canonical Desktop Team (canonical-desktop-team)
tags: added: patch
Changed in gnome-settings-daemon (Ubuntu):
status: Triaged → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 2.30.2-0ubuntu3

---------------
gnome-settings-daemon (2.30.2-0ubuntu3) maverick; urgency=low

  * debian/control.in:
    - requires libindicator-application 0.2.4 for label support
  * debian/patches/06_use_application_indicator.patch:
    - updated version by Karl Lattimer porting the keyboard layout to indicators
      now that indicator-application supports labels (lp: #599844)
  * debian/control.in, debian/rules:
    - use dh-autoreconf
 -- Sebastien Bacher <email address hidden> Tue, 17 Aug 2010 19:21:57 +0200

Changed in gnome-settings-daemon (Ubuntu):
status: Fix Committed → Fix Released
Karl Lattimer (karl-qdh) wrote :
Changed in gnome-settings-daemon (Ubuntu):
assignee: Canonical Desktop Team (canonical-desktop-team) → Karl Lattimer (karl-qdh)
Changed in ayatana-ubuntu:
assignee: nobody → Karl Lattimer (karl-qdh)
Karl Lattimer (karl-qdh) on 2010-08-20
Changed in gnome-settings-daemon (Ubuntu):
status: Fix Released → In Progress
Karl Lattimer (karl-qdh) wrote :
Karl Lattimer (karl-qdh) wrote :

The package will be available shortly from the ppa: https://launchpad.net/~karl-qdh/+archive/ppa

Changed in gnome-settings-daemon (Ubuntu):
status: In Progress → Fix Committed
Sebastien Bacher (seb128) wrote :

gnome-settings-daemon (2.30.2-0ubuntu4) maverick; urgency=low

  * 06_use_application_indicator.patch: update by Karl Lattimer to fix those
    - keyboard indicator does not react to layout changes (lp: #531290)
    - indicator variants in a same layout displayed the same way (lp: #620334)
    - move keyboard layouts out of the submenu (lp: #620571)

Changed in gnome-settings-daemon (Ubuntu):
status: Fix Committed → Fix Released
Karl Lattimer (karl-qdh) wrote :

Update to the patch to use the smallest possible indicator size XXX when only 3 letter labels are used.

Is anyone working on an Ubuntu Mono style icon for the keyboard indicator?

 affects: ayatana-design

Mark

Karl Lattimer (karl-qdh) wrote :

Vish has already made one that's currently used by ibus as the default icon, having two identical icons may end up being confusing if someone uses both. We've got a further discussion about the icon here;

https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/620331

Sebastien Bacher (seb128) wrote :

Thanks Karl, I will probably wait next week to batch that update with some of the others fixes that might come there

Karl Lattimer (karl-qdh) wrote :

The last comment refers to a bug which isn't in gsd, apparently according to tedg a release for a fix is due.

Changed in ayatana-ubuntu:
status: In Progress → Fix Released
status: Fix Released → Fix Committed
Changed in ayatana-design:
status: New → Fix Committed
status: Fix Committed → Fix Released
Changed in ayatana-ubuntu:
status: Fix Committed → Fix Released
Karl Lattimer (karl-qdh) wrote :

This minor update means that if show_flags is enabled the indicator will only show an icon. This emulates exactly the behavior of the notification-area icon as it currently exists upstream.

The reason for this is that the complaint of too much space being used is perfectly valid, and this makes it much easier for us to drop in a pack of icons, set the gconf key and have exactly what MPT wants as per the screenshot here; http://img243.imageshack.us/img243/7358/screenshotnw.png

which was attached to bug; https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/623435

Karl Lattimer (karl-qdh) wrote :

Completing the indicator as specified will only require implementing symbolic svg icons for the "flags" which as previously discussed will not actually be flags, but instead two letters inside of a box.

See the bug regarding this here; https://bugs.launchpad.net/ayatana-ubuntu/+bug/628015

To post a comment you must log in.