Genre "Classic" should be "Classical"

Reported by kroq-gar78 on 2012-04-04
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ayatana Design
Low
John Lea
Music Lens
Undecided
kroq-gar78
unity-lens-music (Ubuntu)
Undecided
Unassigned

Bug Description

Ubuntu 12.04 Beta 2

One of the genre filter names in unity-lens-music is "Classic". I, personally, have never heard music called this except colloquially, like, "Yeah, that's classic stuff..." When I click the "Classic" filter, I get music I tagged (in the genre field) as "Classical". Therefore, I believe it should be called "Classical" instead of "Classic".

Related branches

lp:~kroq-gar78/unity-lens-music/fix-972987
Merged into lp:unity-lens-music at revision 125
Michal Hruby: Approve on 2013-01-10
PS Jenkins bot: Pending (continuous-integration) requested 2013-01-10
kroq-gar78 (kroq-gar78) wrote :

I'll attach my patch for the Ubuntu branch (the Ubuntu branch has extra *.c files, hence the reason why I chose the Ubuntu branch). This nor the branch have been tested yet, by the way.

Changed in unity-lens-music:
assignee: nobody → kroq-gar78 (kroq-gar78)
kroq-gar78 (kroq-gar78) on 2012-04-05
Changed in unity-lens-music:
status: New → In Progress
kroq-gar78 (kroq-gar78) wrote :

I'll set my branch to merge. I tested it and it works. If you (developers) think it should be "Classic" and not "Classical", just reject my merge.

Michal Hruby (mhr3) wrote :

We'll wait for the design team to decide on this, unfortunately Precise is already past string freeze so it can't be merged right now anyway. Hold tight! ;)

kroq-gar78 (kroq-gar78) on 2012-05-03
Changed in unity-lens-music:
status: In Progress → Fix Committed
kroq-gar78 (kroq-gar78) wrote :

Sorry about that "Fix Committed" status!

Changed in unity-lens-music:
status: Fix Committed → In Progress
John Lea (johnlea) wrote :

Does the word "Classical" fit in the existing button? If so +1 from design.

Changed in ayatana-design:
status: New → Fix Committed
assignee: nobody → John Lea (johnlea)
importance: Undecided → Low

The attachment "Change 'classic' to 'classical'" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Changed in unity-lens-music:
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-lens-music - 6.8.1daily13.01.11-0ubuntu1

---------------
unity-lens-music (6.8.1daily13.01.11-0ubuntu1) raring; urgency=low

  [ Alejandro J. Cura ]
  * debian/control:
    - added libsoup2.4-dev and liboauth-dev build dependencies

  [ Michael Terry ]
  * Update vala code to latest 0.18 standards (LP: #1087393)

  [ Iain Lane <email address hidden>, Michael Terry ]
  * Port to GStreamer 1.0 (LP: #1087426)

  [ Alejandro J. Cura ]
  * Needs to call Ubuntu One music store webservices (LP: #1088935)

  [ Aditya Vaidya ]
  * Genre "Classic" should be "Classical" (LP: #972987)

  [ Automatic PS uploader ]
  * Automatic snapshot from revision 125
 -- Automatic PS uploader <email address hidden> Fri, 11 Jan 2013 04:01:55 +0000

Changed in unity-lens-music (Ubuntu):
status: New → Fix Released
John Lea (johnlea) on 2013-06-20
Changed in ayatana-design:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers