Files lens should use base 10 for the file size filter

Reported by Mikkel Kamstrup Erlandsen on 2011-10-27
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Undecided
Unassigned
Unity
Undecided
Unassigned
unity-lens-files
Undecided
Unassigned
unity-lens-files (Ubuntu)
Undecided
Unassigned

Bug Description

According to https://wiki.ubuntu.com/UnitsPolicy (which does not make clear who is endorsing it (?)) we should be using base 10 units in the file size filter for the files lens.

Related branches

lp:~mihaic/unity-lens-files/base-10-file-size-units-fix
Merged into lp:unity-lens-files at revision 257
PS Jenkins bot: Approve (continuous-integration) on 2013-06-21
Mihai Capotă (community): Approve on 2013-06-21
Michael Terry: Approve on 2013-06-21

Marked Incomplete to trigger the design review process

Changed in unity-lens-files:
status: New → Incomplete
Mihai Capotă (mihaic) wrote :

While waiting for the review, consider that Nautilus already uses base 10 units.

Changed in unity:
status: New → Incomplete
tags: added: needs-design
John Lea (johnlea) wrote :

@kamstrup; currently we have:

1KB
10KB
1MB
10MB
100MB
1GB

Could you comment on the exact set you would like to see if we were to make this change?

thanks,
John

Mihai Capotă (mihaic) wrote :

Any decision on this? It's a simple patch that will make the file lens consistent with Nautilus.

Sebastien Bacher (seb128) wrote :

John, those units are base 2 units (1k=1024), the suggested change is to use the S.I unit (1k=1000)

John Lea (johnlea) wrote :

@seb128 or @mihaic; could you list the exact set of options that would be presented to the user if we made this change?

Mihai Capotă (mihaic) wrote :

@johnlea I don't particularly care what intervals are presented to the user, as long as the meaning is the same as in Nautilus. Still, to answer your question, I would like to see this:

1 kB
100 kB
1 MB
10 MB
100 MB
1 GB

Note that technically there should also be a space between the value and the unit, which I did not add in the patch I submitted, since there is little available space in the interface.

Michael Terry (mterry) wrote :

Poke on this. I'd personally just push the branch through, since the UnitsPolicy page has been around for a while, has been discussed at UDS's, and is followed by the rest of the desktop. But since we have this bug open, I don't want to act unilaterally. I'm just surprised it's taken this long.

John Lea (johnlea) wrote :

@mterry; go for it as long as the intervals in the UI remain as:

1kB (or 1KB)
10kB (or 10KB)
1MB
10MB
100MB
1GB

PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity-lens-files at revision 257, scheduled for release in unity-lens-files, milestone 7.1.0

Changed in unity-lens-files:
status: Incomplete → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-lens-files - 7.1.0daily13.06.24-0ubuntu1

---------------
unity-lens-files (7.1.0daily13.06.24-0ubuntu1) saucy; urgency=low

  [ Mihai Capotă ]
  * Use base-10 units for file size. (LP: #882352)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 257
 -- Ubuntu daily release <email address hidden> Mon, 24 Jun 2013 05:41:15 +0000

Changed in unity-lens-files (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers