Dash - Preview activation doesn't have instant feedback
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ayatana Design |
Fix Released
|
High
|
John Lea | ||
| Unity |
Fix Released
|
High
|
Nick Dedekind | ||
| 6.0 |
Won't Fix
|
High
|
Unassigned | ||
| unity (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bug Description
When a Preview needs to fetch online data, it can take a moment before being displayed.
After a click on a result, there is no visual feedback on what is happening and no way to know if the click has been acknoweldged by the Dash.
This could be fixed in different ways:
- Showing a spinner on the result icon.
- Showing a spinner on the cursor.
- Instantly opening the preview pane, with, as a transition : the result icon on the left pane, the result title on the right, a spinner on top (the same as the one appearing when navigating between previews) and updating the content when the actual preview data is here.
-------
Desired solution:
When the user opens a preview that is not pre-chached, the preview should open instantly, and the content should then load into the already opened preview. A spinner can be displayed in the place of the image to inform the user that the preview is loading.
Related branches
- Gord Allott (community): Approve
- Michal Hruby (community): Needs Fixing
- Brandon Schaefer (community): Approve
-
Diff: 674 lines (+157/-147)15 files modifieddash/CoverflowResultView.cpp (+25/-13)
dash/CoverflowResultView.h (+3/-0)
dash/DashController.cpp (+0/-1)
dash/DashView.cpp (+37/-40)
dash/DashView.h (+3/-4)
dash/LensView.cpp (+15/-9)
dash/LensView.h (+2/-2)
dash/PreviewStateMachine.cpp (+1/-4)
dash/ResultView.cpp (+1/-0)
dash/ResultView.h (+3/-1)
dash/ResultViewGrid.cpp (+39/-61)
dash/ResultViewGrid.h (+2/-0)
dash/previews/PreviewContainer.cpp (+9/-8)
manual-tests/Preview.txt (+17/-0)
unity-shared/UBusMessages.h (+0/-4)
| Changed in unity: | |
| assignee: | nobody → Nick Dedekind (nick-dedekind) |
| description: | updated |
| tags: | added: udp |
| Changed in ayatana-design: | |
| assignee: | nobody → John Lea (johnlea) |
| status: | New → Triaged |
| Changed in unity: | |
| status: | New → Triaged |
| Changed in unity (Ubuntu): | |
| status: | New → Triaged |
| Changed in ayatana-design: | |
| importance: | Undecided → High |
| Changed in unity: | |
| importance: | Undecided → High |
| Changed in unity (Ubuntu): | |
| importance: | Undecided → High |
| Changed in unity: | |
| milestone: | none → backlog |
| summary: |
- Preview activation doesn't have instant feedback + Dash - Preview activation doesn't have instant feedback |
| Changed in ayatana-design: | |
| status: | Triaged → Fix Committed |
| tags: | added: dashm |
| Changed in unity: | |
| milestone: | backlog → none |
| tags: | added: exbacklog |
| Changed in unity: | |
| milestone: | none → 7.0 |
| status: | Triaged → In Progress |
| Changed in unity (Ubuntu): | |
| status: | Triaged → In Progress |
| Changed in unity: | |
| status: | In Progress → Fix Committed |
| Timo Jyrinki (timo-jyrinki) wrote | #1 |
| description: | updated |
| Changed in unity (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
| Changed in unity: | |
| status: | Fix Released → Fix Committed |
| Stephen M. Webb (bregma) wrote | #2 |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
| Changed in ayatana-design: | |
| status: | Fix Committed → Fix Released |
This would need UIFe, therefore decided not to test for inclusion in 6.8.0.