Awn

Task manager show window with _NET_WM_STATE_SKIP_TASKBAR

Bug #699772 reported by Cédric Bellegarde
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Awn
Fix Released
Low
moonbeam

Bug Description

http://adishatz.1s.fr/~gnumdk/awn.ogv

On this video, you will see taskmanager show an icon when meteo applet close it popup window.

It happen also with some plasma popup widget, only when popup is closing...

Tags: taskmanager

Related branches

Revision history for this message
moonbeam (rcryderman) wrote :

what is the Window Manager?

Revision history for this message
moonbeam (rcryderman) wrote :

Ah nvm.... I see "plasma popup" so I'm guessing kwin.

Revision history for this message
Cédric Bellegarde (gnumdk) wrote :

The window manager is Kwin.

You're right, no issue with compiz...

But, what is strange is that nothin appear in others taskmanagers (kde, docky, cairo-dock, ...)

Revision history for this message
Cédric Bellegarde (gnumdk) wrote :

I test with gnome-panel wnck applet and nothing appear when this kind of window is closed...

Best way to reproduce this with kwin:
- Click on an applet with an popup (calendar for clock applet)
- Click on another window (background, any open window)
- Awn show the window in tasklist while closing.

I try some debug...

What I see is that task_window_set_window() receive a WnckWindow (for plasma popup and awn popup) with SKIP_TASKBAR unset...

Revision history for this message
Cédric Bellegarde (gnumdk) wrote :

I find a way to fix the issue...

In task-manager.c, i just add this:

if (wnck_window_is_skip_tasklist(window)) return;

And it fix the issue, looks good ?

Revision history for this message
Cédric Bellegarde (gnumdk) wrote :

Hmm, more information:

in task-manager.c => process_window_opened() i see this:

   for some reason the skip tasklist property for the taskmanager toggles briefly
   off and on in certain circumstances. Nip this in the bud.
   TODO: Investigate wth this is happening... it bothers me.
   */
// if ( wnck_window_get_pid (window) == getpid() ||
  if ( g_strcmp0 (wnck_window_get_name (window),"awn-applet")==0 )
  {
    return;
  }
  /*
   * Monitors state change to and from skip tasklist.
   */
  g_signal_connect (window, "state-changed", G_CALLBACK (on_window_state_changed), manager);

  if (wnck_window_is_skip_tasklist (window))
  {
    return;
  }

but if you look at wnck_window_is_skip_tasklist() in on_window_opened(), it works so, will try with removing previous code, check in on_window_opened() send patch here and test for some days...

Revision history for this message
Cédric Bellegarde (gnumdk) wrote :

https://aur.archlinux.org/packages/avant-window-navigator-kde/avant-window-navigator-kde/

Patch is "fix_skip_task_list.diff"

Testing awn for some days with this patch enabled.

Revision history for this message
onox (onox) wrote :

You can attach the patch via the + button below the comment textarea.

Revision history for this message
Cédric Bellegarde (gnumdk) wrote :
moonbeam (rcryderman)
Changed in awn:
assignee: nobody → moonbeam (rcryderman)
Revision history for this message
Cédric Bellegarde (gnumdk) wrote :

It seems to fix issue here with no regression after some days of use.

Revision history for this message
Cédric Bellegarde (gnumdk) wrote :

Any plan to integrate this patch ?

onox (onox)
tags: added: taskmanager
Revision history for this message
moonbeam (rcryderman) wrote :

Next day I have an opportunity work on Awn I'll be reviewing (and probably merging it in some form or other).

Revision history for this message
moonbeam (rcryderman) wrote :

patch applied. thanks.

Changed in awn:
status: New → Fix Committed
onox (onox)
Changed in awn:
milestone: none → 0.4.2
importance: Undecided → Low
Povilas Kanapickas (p12)
Changed in awn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.