Awn

set_awn_icon() doesn't look in the applet's dir

Bug #330110 reported by onox on 2009-02-16
2
Affects Status Importance Assigned to Milestone
Awn
Medium
moonbeam

Bug Description

set_awn_icon() doesn't look in the applet's dir, where the icons of 3rd party applets are (~/.config/awn/applets/<applet>/). Maybe it should look in <applet's dir>/icons/

Related branches

onox (onox) on 2009-02-16
Changed in awn:
assignee: nobody → rcryderman
Michal Hruby (mhr3) on 2009-03-22
Changed in awn:
importance: Undecided → Medium
milestone: none → 0.4.0
status: New → Triaged
moonbeam (rcryderman) wrote :

Fix pushed into rev 791. please test.

Changed in awn:
status: Triaged → Fix Committed
onox (onox) wrote :

I don't use set_awn_icon() anymore in applets. I do use set_icon_name(). I tried to put some randomly chosen .svg icon to <prefix>/applets/thinkhdaps/icons/drive-harddisk.svg, but new instances of the applet still use the system theme's icon. In ThinkHDAPS I use some OverlayThemedIcon and these do seem to look in icons/ (because that's where the icons for the overlays are), so I don't understand why you didn't reuse the code.

Changed in awn:
status: Fix Committed → Confirmed
onox (onox) wrote :

Uhh... insert the necessary share/avant-window-navigator/ in that path in my previous comment.

onox (onox) wrote :

@moonbeam: could you please set the milestone to Awn 0.4.2?

moonbeam (rcryderman) wrote :

Onox,

I will double check, but I'm fairly certain AwnOverlayThemedIcon uses AwnThemedIcon for the icon loads

onox (onox) wrote :

@moonbeam: have you double checked?

moonbeam (rcryderman) on 2011-01-15
Changed in awn:
milestone: 0.4.0 → 0.4.2
moonbeam (rcryderman) wrote :

onox,

After a brief look I'm somewhat surprised AwnOverlayThemedIcon would be pulling in proper icons. I will do some further testing when I get a chance - have some other items higher on my list.

onox (onox) wrote :

If I read my previous comment correctly: OverlayThemedIcon is not the problem. set_icon_name() is the problem because it doesn't look in icons/

moonbeam (rcryderman) wrote :

onox, I was referencing AwnOverlayThemedIcon as you mentioned that it was working properly in comment #2

onox (onox) wrote :

Ok, so now we have both come to the conclusion that AwnOverlayThemedIcon is working, but set_icon_name() is not? :)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers