Awn

AWN doesn't update window's status

Bug #147591 reported by Enlightened on 2007-10-01
12
Affects Status Importance Assigned to Milestone
Awn
High
Michal Hruby
libwnck
Invalid
Medium

Bug Description

The problem is avant-windows-navigator doesn't react somehow on new actions (opens, closes, changing title). It gets currently running apps correctly when it starts, but then it doesn't. Looks like gsignal libwnck are not sent after running awn (except the first time). I use freeBSD 6.2, last awn from bzr, wnck-test (the program in libwnck package) runs ok.

Related branches

Michal Hruby (mhr3) wrote :

Fixed in R136.

Changed in awn:
assignee: nobody → mhr3
importance: Undecided → High
status: Confirmed → Fix Committed
Mark Lee (malept) wrote :

The following patch actually checks the version of libwnck to see if the version installed has the ABI change from version 2.19.3.1 and later.

Michal Hruby (mhr3) wrote :

Thanks, now in trunk R137.

Mark Lee (malept) wrote :

This is minor, but it annoys those of us developers building with the -Wall CFLAG. The following patch compiles only one of the wnck callback functions, to avoid the error "warning: xyz defined but not used."

Mark Lee (malept) wrote :

According to some libwnck 2.20 users, there is a small glitch in awn-wnck-Wall-fix.patch . The following patch is meant to be applied over the former one.

Michal Hruby (mhr3) wrote :

Why did you put the connection of "viewports-changed" signal in the ifdef? This signal is available also in libwnck <2.20.

Michal Hruby (mhr3) wrote :

The doc is wrong, take a look for example here: http://ftp.gnome.org/pub/GNOME/sources/libwnck/2.4/libwnck-2.4.0.1.tar.bz2

The signal is already present there - libwnck/screen.c (libwnck 2.4), maybe it's there even in older releases.

Mark Lee (malept) wrote :

Bug filed with libwnck in Gnome bugzilla. I'll fix the patch shortly.

Mark Lee (malept) wrote :

The following patch *replaces* -rev1, and removes the #ifdef from the "viewports-changed" signal.

Mark Lee (malept) wrote :

Sigh. Via Vincent Untz (libwnck maintainer) in the referenced bug on Gnome bugzilla, it was not part of the public interface until libwnck 2.19.3. In fact, it was introduced in the middle of an "#if 0" block. So, -rev1 is indeed a correct patch.

Michal Hruby (mhr3) wrote :

Thanks for clarifying, but in that case the signal is currently useless for us, and we don't need to connect it at all.

Mark Lee (malept) wrote :

Right, which is why it's #ifdef'd out in -rev1.

Michal Hruby (mhr3) wrote :

Yea, it's #ifdef'd, but it can be removed, we'll have a performance boost and smaller code size. ;D

0.2.1 released

Changed in awn:
status: Fix Committed → Fix Released
Changed in libwnck:
status: Unknown → Invalid
Changed in libwnck:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.