Awn

AWN should act on a change of values immedialty (bar_height/icon_offset

Bug #136858 reported by haytjes on 2007-09-02
2
Affects Status Importance Assigned to Milestone
Awn
Undecided
haytjes

Bug Description

For the change of two values: bar_height and icon_offset it is advised to restart awn to get it properly.
AWN should react immediately on a change of it, therefor this bug report.

haytjes (h4writer) wrote :
Changed in awn:
assignee: nobody → h4writer
status: New → In Progress
haytjes (h4writer) wrote :

It's just to say it isn't finished yet. I'm still busy on it...

haytjes (h4writer) wrote :

Next patch:
The resizing is now good. It has now the right height/offset ... There are still some minor issues:
* when changing icon-offset: the screen where is drawn on isn't getting bigger and if the icon-offset is getting to big the background just stops...
* trash plugin: it isn't claiming more or less space => the icon is chop off

But we have almost dynamic resizing \o/
(Can someone confirm, I didn't missed something? So it's working for everyone!)

Ryan Rushton (ryancr) wrote :

I see the same issues here as you described above, other than those it seems to work fine, nice not have to reload/restart.

The main menu and stack applet don't resize, but I assume that its the applets fault.

Ryan Rushton (ryancr) wrote :

Oh and the main menu and stack applet won't change there icon_offset either, a restart is required for that,

haytjes (h4writer) wrote :

Yeah, I'm currently not looking to the other applets. They probably don't handle the resize event good. (It's straightforward to change it).

Now I have a new patch. It is less 'stable' (I mean it does the 3d view not perfect), but is usable. This patch should fix the icon-offset getting to big so that the top part isn't visible anymore. I had to position everything of the awn-bar again, that's why it wasn't that easy and therefor there could be some things that I missed.

Issues:
* trash plugin: it isn't claiming more or less space => the icon is chop off
* main-menu plugin: doesn't resize (height & icon_offset)
* stack applet: doesn't resize (height & icon_offset)

haytjes (h4writer) wrote :

I compared the trunk to this and I can say they look identical. Thought I would forget something or changed something wrong, but they just look the same :-D. Now busy to adjust the other issues.
(Can you give me the url to the main-menu and the stack applets. That way I don't need to search myself.)

haytjes (h4writer) wrote :

It took longer than expected (was busy to resize the wrong item), but here a patch where the trash plugin is resizing properly.

Open issues:
* main-menu plugin: doesn't resize (height & icon_offset)
* stack applet: doesn't resize (height & icon_offset)

haytjes (h4writer) wrote :

For now I set this as 'Fix committed', when I get the other ones, I will change them to.

Changed in awn:
status: In Progress → Fix Committed
Ryan Rushton (ryancr) wrote :

Stacks patch can be found here:
http://patch-manager.dskw.de/?do=patch&id=49

main-menu: is just in with the awn-extras

haytjes (h4writer) wrote :

Will look to these, once my other patches are done.

Changed in awn:
status: Fix Committed → In Progress
haytjes (h4writer) wrote :

yeah, for main-menu libawn/awn-applet-simple need to get patched. I tried already something, but it isn't working. God I hate gconf and notify. These just won't work with me. Will try another day.

haytjes (h4writer) wrote :

And here I am with the a working patch. Still an issue is:
main-menu gives an icon (with a predefined width) from the start to awn-simple. If you change the bar_height afterwardse the height of the icon doesn't change. Don't know how to change it properly.

haytjes (h4writer) wrote :

Still not done, but now the icon_height is changed. There still need to come a way to notify the applet, so a new icon with the right dimensions can be set (and that has a better quality). Because now I'm just scaling the icon I received (what can make the icon ugly)

haytjes (h4writer) wrote :
haytjes (h4writer) wrote :
haytjes (h4writer) on 2007-09-13
Changed in awn:
status: In Progress → Fix Committed
Changed in awn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers