Awn

[patch] Separator flickering when opening/closing task

Bug #133009 reported by Michal Hruby on 2007-08-16
2
Affects Status Importance Assigned to Milestone
Awn
Undecided
haytjes

Bug Description

When you open new task, or close existing, the separator between launchers and tasks moves unnaturally (jumps/flickers), this patch will make it move smoothly as the window resizes.

Michal Hruby (mhr3) wrote :

Patch against trunk R38.

haytjes (h4writer) wrote :

I think you forgot some stuff (but it's normal, the code is hard to read...)

I didn't tested it, but I think this patch changes everything (3D look, separator applet ...)

Changed in awn:
assignee: nobody → h4writer
status: New → In Progress
Michal Hruby (mhr3) wrote :

Right, I didn't use separator applets, that's why I didn't notice it, so this one finishes what I started. (sorry, but your patch didn't do the job) Anyway, thanks for pointing it out.

haytjes (h4writer) wrote :

Still one question: Did you tried it with '3d look' or 'leopard look'?

Because this piece of code:
- if (settings->bar_angle != 0)
- {
- if(settings->icon_offset-3<=height/4)
- real_x += apply_perspective_x(width, settings->icon_offset-3, 0);
- else
- real_x += apply_perspective_x(width, height/4, 0);
- }

is for setting the offset right in the '3d look' and because you delete that I think the separators aren't on there place anymore...

Michal Hruby (mhr3) wrote :

If ('3d look' == 'leopard look') then yea, I did, I use 3d look by default, and it looks just as original with my patch. Note that the most important change is the dest_width -> current_width.

Thanks for the patch. Committed.

Changed in awn:
status: In Progress → Fix Committed
Changed in awn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers