Cairo Menu: Icons are not updated at theme change

Bug #629698 reported by Gabor Karsay
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Awn Extras
New
Undecided
moonbeam

Bug Description

If the GTK theme is changed, the icons in Cairo Menu are not changed until it is restarted. (The applet's icon in the panel changes, but not the icons in the menu.)

This patch shoud fix it:
In function get_gtk_image it uses gtk_image_new_from_icon_name. This returns icons that are automatically updated, you don't have to do anything about it! The scaling of images from file is done in one step, previously in two steps. Unless this was a workaround for a bug or something, I think it is not necessary.

In function _get_places_menu it listens to theme changes and updates itself, because some icons may be missing in the new theme, on update the existing ones are selected.

And it changes one icon name from "stock-folder" to "folder-home" that was introduced in the last commit, that makes fallback icons possible (I really think this was unintentional). Anyway, thanks a lot for that fix, onox.

Revision history for this message
Gabor Karsay (gabor-karsay) wrote :
Revision history for this message
moonbeam (rcryderman) wrote :

I'll change the "folder-home" now. You are correct, it was a typo.

I'll need to look over the other issue. I believe there was a specific behaviour I was working around with the existing code (I think using the method in the patch results in some oversized icons being used with certain icon themes), but I'll need to jog my memory a bit more.

Thanks.

onox (onox)
Changed in awn-extras:
assignee: nobody → moonbeam (rcryderman)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.