Comment 22 for bug 278388

>Aren't we shipping a default "url"? If so, this seems like it would
>only help if someone manually deleted that gconf key or something
>weird.

Well, in theory we will, but until there is a schema file shipping the url, this is needed.

> There are three duplicated lines in the try and the except. Shouldn't
> that be in a finally, or after the try/except?

Right you are...

> Also I am not quite sure what is going on here, you try to load the URL
> from the config, but then you parse it from the web anyway? In other
> words, it doesn't seem like the value that is persisted is ever really used
> except to get some meta content type.

I also wondered about this, but was mostly concerned with getting the patch into
shape that worked with current trunk, not changing the approach. I added the try/except
after testing to see if this would actually work with a wrong url and getting a HTMLError
from urllib2.urlopen(pandurl).

I assume that the reason for getting the meta content is to make sure that the
page being opened is in fact the flash player and not something else.

Any way, as this does work for me. I'm going to fix it up a little more, and then push
to trunk so others can work on it as well.

Thanks for the patch Kevin W!