stacks_gui_curved.py can not display images very well

[Peng Huang]

Stacks can not display images very well with curved gui. The images have a weird border. I think it's because of the icons do not have alpha channel. Below patch can fix this problem. But this patch will create new icons every time when drawing icons. It is not effective. You may create icon with alpha channel when loading the icon. (I did find the right place for icon loading )

=== modified file 'awn-applets/awn-extras-applets/src/stacks/stacks_gui_curved.py'
--- awn-applets/awn-extras-applets/src/stacks/stacks_gui_curved.py 2007-12-11 01:05:17 +0000
+++ awn-applets/awn-extras-applets/src/stacks/stacks_gui_curved.py 2007-12-13 07:38:36 +0000
@@ -910,7 +910,7 @@
                if iw < icon_size: x_adjust = (iw - icon_size) / 2
                if ih < icon_size: y_adjust = (ih - icon_size) / 2

- context.set_source_pixbuf(icon,x+x_adjust,y-y_adjust)
+ context.set_source_pixbuf(icon.add_alpha (True, '\0', '\0', '\0'), x + x_adjust, y - y_adjust)
                context.fill()
                context.paint()

[Silentstorm (silentstorm)]

Thanks for reporting this bug,
I will take a look at it.

[Silentstorm (silentstorm)]

It should be fixed in the following files

(contains stacks_gui_curved.py and stacks_icons.py)

- add alpha channel to the icon when it is loaded
- better adjustment of the x coordinate of the icon when it is smaller than the defined icon size.
- some support for the new configuration settings (not visible yet)

again thx for reporting this bug, and providing the proper solution.

[moonbeam (rcryderman)]

http://codebrowse.launchpad.net/~awn-extras/awn-extras/trunk/revision/255

[Silentstorm (silentstorm)]

patch for the bug introduced with the previous patch ........ (uploaded wrong version)

http://www.mediafire.com/?a9lpmmxh423

[moonbeam (rcryderman)]

http://codebrowse.launchpad.net/~awn-extras/awn-extras/trunk/revision/256

[Peng Huang (shawn-p-huang)]

What is drawForeground for in stacks_gui_curved.py? Can it be removed?

[Silentstorm (silentstorm)]

It draws a semi transparent shine above the icon, it won't hurt to disable or remove it.

why?

[Peng Huang (shawn-p-huang)]

I just can not see any different with or without it in my box. :)

[Silentstorm (silentstorm)]

It will depend on your screencontrast, but it will be more configurable in the near future

[Andrew Starr-Bochicchio (andrewsomething)]

New release: https://edge.launchpad.net/awn-extras/0.2/0.2.4