mirage_miximize fails to enqueue songs that have unicode characters in their filenames

Bug #847026 reported by Naglis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
autoqueue
Fix Committed
Medium
Eric Casteleijn

Bug Description

Hi Eric,

While miximizing a set (~90) of songs it came to attention that the plugin would fail to enqueue songs with Unicode characters in their filenames. Quod Libet would throw this error:

=== SYSTEM INFORMATION:
Quod Libet 2.3.1.-1
Mutagen 1.20.-1
Python 2.7.2+ (default, Aug 16 2011, 07:29:45)
[GCC 4.6.1] linux2

=== STACK TRACE
Traceback (most recent call last):

  File "/usr/lib/python2.7/dist-packages/dbus/connection.py", line 586, in msg_reply_handler
    reply_handler(*message.get_args_list(**get_args_opts))

  File "/home/naglis/.quodlibet/plugins/songsmenu/mirage_miximize.py", line 36, in player_enqueue
    (self._songs[filename] for filename in filenames))

  File "/usr/lib/pymodules/python2.7/quodlibet/qltk/songlist.py", line 83, in enqueue
    for song in songs:

  File "/home/naglis/.quodlibet/plugins/songsmenu/mirage_miximize.py", line 36, in <genexpr>
    (self._songs[filename] for filename in filenames))

KeyError: dbus.String(u'/home/naglis/Muzika/__/R\xf6yksopp - Melody A.M. - 01 - So Easy.mp3')

The attached small patch solved the problem for me, yet I'm not sure if it's the best solution.

BTW, thank you for this plugin, I find it really useful!

Naglis

Revision history for this message
Naglis (njonaitis-deactivatedaccount) wrote :
Revision history for this message
Eric Casteleijn (thisfred) wrote :

Hi Naglis,

thanks very much for your bug report! I hopefully fixed the issue, though in a slightly different way (avoiding encoding/decoding filenames altogether, which is a thorny issue in itself, and only made worse by DBus' weird wrappers.)

Please test that this fixes the issue for you. (The fix is in trunk now, if you install from source. If you're using the PPA, a new build should be available sometime soon.)

Changed in autoqueue:
assignee: nobody → Eric Casteleijn (thisfred)
importance: Undecided → Medium
status: New → Fix Committed
Revision history for this message
Naglis (njonaitis-deactivatedaccount) wrote :

Yes, the issue looks fixed.

Thanks!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.