Autopilot tests that involve special keys fail

[Olivier Tilloy]

I upgraded my laptop running xenial+overlay to yakkety then zesty yesterday, and since then all webbrowser-app autopilot tests that involve pressing special keys or key combinations (like 'Escape', 'F6' or 'Ctrl+plus') are consistently failing:

Traceback (most recent call last):
  File "/build/webbrowser-app/staging/tests/autopilot/webbrowser_app/tests/test_fullscreen.py", line 70, in test_user_exit_ESC
    self.main_window.press_key('Escape')
  File "/build/webbrowser-app/staging/tests/autopilot/webbrowser_app/emulators/browser.py", line 192, in press_key
    self.keyboard.press_and_release(key)
  File "/usr/lib/python3/dist-packages/autopilot/input/_uinput.py", line 181, in press_and_release
    self.press(keys, delay)
  File "/usr/lib/python3/dist-packages/autopilot/input/_uinput.py", line 138, in press
    self._device.press(key_button)
  File "/usr/lib/python3/dist-packages/autopilot/input/_uinput.py", line 56, in press
    ecode = self._get_ecode_for_key(key)
  File "/usr/lib/python3/dist-packages/autopilot/input/_uinput.py", line 66, in _get_ecode_for_key
    raise ValueError('Unknown key name: %s.' % key)
ValueError: Unknown key name: Escape.

[Olivier Tilloy (osomon)]

And the same tests also fail in a virtualbox xenial+overlay guest. I’m pretty sure they used to pass in that same guest when the host was running xenial+overlay.

[Andrew Hayzen (ahayzen)]

This also occurs for me on xenial+overlay, but i have found changing the key from "Escape" to "Esc" fixes the problem.

[Olivier Tilloy (osomon)]

And changing references to function keys such as 'F11' to 'f11' fixes that case too.

References to Ctrl+<key> combinations are still failing.

[Olivier Tilloy (osomon)]

References to Ctrl+<key> function as expected when I switch my keyboard layout to qwerty before running the tests. I think this is bug #1108742, which had disappeared, but is back.

[Olivier Tilloy (osomon)]

I’m observing that references to 'Ctrl+Page_Down' don’t work any longer, changing them to 'Ctrl+PageDown' fix the issue (had to remove the underscore from 'Page_Down', and same for 'Page_Up').

[Olivier Tilloy (osomon)]

And I haven’t yet found a working replacement for the 'Ctrl+plus' key combination ('Ctrl+minus' seems to be working fine).

[Olivier Tilloy (osomon)]

Replacing 'Ctrl+plus' with 'Ctrl+equal' does the trick, although it’s not semantically equivalent.

[Santiago Baldassin (sbaldassin)]

https://code.launchpad.net/~sbaldassin/autopilot/fix_1671155/+merge/319367

[platform-qa-bot (platform-qa-bot)]

Fix committed into lp:autopilot at revision None, scheduled for release in autopilot, milestone 1.4