| 2015-02-25 22:15:57 |
Christopher Lee |
bug |
|
|
added bug |
| 2015-02-26 00:40:23 |
Christopher Lee |
description |
Related to this bug: lp:1376996 where the fix for that introduced other issues for existing application test cases this code needs to be fixed so this aforementioned bug is fixed completely. |
Related to this bug: lp:1376996 where the fix for that introduced other issues for existing application test cases this code needs to be fixed so this aforementioned bug is fixed completely.
The actual bug is that the extension classes aren't applied in the call to `_try_custom_proxy_classes`, the initial fix (now reverted) attempted this but this introduced unforeseen errors when running all the application tests. A further quick fix was attempted (effectively:
base + tuple(set(extensions).difference(base))
)
But this introduced other errors and at that point the quick fix was no longer quick.
This bug is slated for the next projects team sprint to fix. |
|
| 2015-05-21 18:16:27 |
Christopher Lee |
summary |
Handling of extension classes and bases classes needs revamped |
Extension classes with multiple base classes aren't merged correctly. |
|
| 2015-05-22 15:24:28 |
Christopher Lee |
autopilot: status |
Confirmed |
Fix Released |
|
| 2015-05-22 16:33:09 |
Christopher Lee |
description |
Related to this bug: lp:1376996 where the fix for that introduced other issues for existing application test cases this code needs to be fixed so this aforementioned bug is fixed completely.
The actual bug is that the extension classes aren't applied in the call to `_try_custom_proxy_classes`, the initial fix (now reverted) attempted this but this introduced unforeseen errors when running all the application tests. A further quick fix was attempted (effectively:
base + tuple(set(extensions).difference(base))
)
But this introduced other errors and at that point the quick fix was no longer quick.
This bug is slated for the next projects team sprint to fix. |
Related to this bug: lp:1376996 where the fix for that introduced other issues for existing application test cases this code needs to be fixed so this aforementioned bug is fixed completely.
The actual bug is that the extension classes aren't applied in the call to `_try_custom_proxy_classes`, the initial fix (now reverted) attempted this but this introduced unforeseen errors when running all the application tests. A further quick fix was attempted (effectively:
base + tuple(set(extensions).difference(base))
)
But this introduced other errors and at that point the quick fix was no longer quick.
[Impact]
* It is possible that a test authors tests fail intermittently due to the base classes of a cpo not being resolved correctly and thus added methods etc. are not available (resulting in an attribute failure).
* justification: Ensures that test author tests for applications have a decreased likelihood of failing
* This fix improves the handling of the what is expected when using a custom proxy object and is stricter in what it allows.
[Test Case]
* To reproduce this bug:
- Install the current python3-autopilot (apt-get install python3-autopilot python-windowmocker)
- run this test (using the following command):
$ python3 -m autopilot.run run autopilot.tests.functional.test_introspection_features.IntrospectionFeatureTests.test_customised_proxy_classes_have_extension_classes
[Regression Potential]
* Changes to the existing core app autopilot tests have been landed, otherwise there would be a potential regression where tests start failing with an exception [1].
[1] ValueError with the message starting: "base_class: {passed} does not appear to be the actual base CPO class."
* This change has been tested against the existing core app tests (Using a jenkins job similar to the smokeeng dash board) where all the tests are run. The results are inspected. |
|
| 2015-05-22 16:33:43 |
Łukasz Zemczak |
bug task added |
|
autopilot (Ubuntu) |
|
| 2015-05-22 16:33:54 |
Łukasz Zemczak |
nominated for series |
|
Ubuntu Vivid |
|
| 2015-05-22 16:33:54 |
Łukasz Zemczak |
bug task added |
|
autopilot (Ubuntu Vivid) |
|
| 2015-06-02 06:26:39 |
Steve Langasek |
autopilot (Ubuntu Vivid): status |
New |
Fix Committed |
|
| 2015-06-02 06:26:40 |
Steve Langasek |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2015-06-02 06:26:44 |
Steve Langasek |
bug |
|
|
added subscriber SRU Verification |
| 2015-06-02 06:26:47 |
Steve Langasek |
tags |
|
verification-needed |
|
| 2015-06-08 22:42:46 |
Christopher Lee |
tags |
verification-needed |
verification-done |
|
| 2015-06-10 18:20:15 |
Chris J Arges |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2015-06-10 18:25:22 |
Launchpad Janitor |
autopilot (Ubuntu Vivid): status |
Fix Committed |
Fix Released |
|
| 2015-07-24 01:27:12 |
Launchpad Janitor |
autopilot (Ubuntu): status |
New |
Fix Released |
|
| 2016-08-18 18:43:17 |
Launchpad Janitor |
branch linked |
|
lp:~ci-train-bot/autopilot/autopilot-ubuntu-yakkety-landing-063 |
|
