| 2015-05-22 16:49:27 |
Christopher Lee |
description |
The -v option in autopilot run should print logged messages, but not too many. Currently, with -v everything in debug is printed, which is too much. For example, when making a finger move, we get:
[...]
19:54:21.865 DEBUG _uinput:414 - Moving pointing 'finger' to position 270,116.
19:54:21.866 DEBUG _uinput:419 - The pointing 'finger' is now at position 270,116.
19:54:21.878 DEBUG _uinput:414 - Moving pointing 'finger' to position 270,110.
19:54:21.880 DEBUG _uinput:419 - The pointing 'finger' is now at position 270,110.
19:54:21.891 DEBUG _uinput:414 - Moving pointing 'finger' to position 270,104.
19:54:21.893 DEBUG _uinput:419 - The pointing 'finger' is now at position 270,104.
[...]
That's one line per pixel.
I think that -v should only print the info logging level. That way the test writer decides what goes into the -v log, and we can use it to put information about the high level user actions that the test executes, like "drag from the bottom", instead of the many finger moves.
Then, -vv should be the current -v, printing also the debug level in case we need extra information.
And we can add a -vvv to be the new -vv. |
The -v option in autopilot run should print logged messages, but not too many. Currently, with -v everything in debug is printed, which is too much. For example, when making a finger move, we get:
[...]
19:54:21.865 DEBUG _uinput:414 - Moving pointing 'finger' to position 270,116.
19:54:21.866 DEBUG _uinput:419 - The pointing 'finger' is now at position 270,116.
19:54:21.878 DEBUG _uinput:414 - Moving pointing 'finger' to position 270,110.
19:54:21.880 DEBUG _uinput:419 - The pointing 'finger' is now at position 270,110.
19:54:21.891 DEBUG _uinput:414 - Moving pointing 'finger' to position 270,104.
19:54:21.893 DEBUG _uinput:419 - The pointing 'finger' is now at position 270,104.
[...]
That's one line per pixel.
I think that -v should only print the info logging level. That way the test writer decides what goes into the -v log, and we can use it to put information about the high level user actions that the test executes, like "drag from the bottom", instead of the many finger moves.
Then, -vv should be the current -v, printing also the debug level in case we need extra information.
And we can add a -vvv to be the new -vv.
[Impact]
* Current logging levels are incorrect and cause a huge amount of un-needed details to be output during normal runs.
* justification: Streamlines seeing issues in test run logs
* This fix improves the quality of the logging output which is essential for debugging test failures.
[Test Case]
* To reproduce this bug:
- Install the current python3-autopilot (apt-get install python3-autopilot)
- run this test (using the following command):
$ python3 -m autopilot.run run -v autopilot.tests.functional.test_input_stack.InputStackKeyboardTypingTests.test_text_typing
- Observe the abundance of messages similar to:
04:47:46.152 DEBUG _X11:237 - Sending release event for key: '
04:47:46.188 DEBUG _X11:234 - Sending press event for key: <
- With the fixed release there will be no DEBUG level messages.
[Regression Potential]
* That the logging output is different than expected |
|
