add_source() might fail due to network errors
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Autopilot Log Analyser |
Fix Released
|
Low
|
Francis Ginther | ||
Charm Helpers |
Fix Released
|
Undecided
|
Chad Smith | ||
Glance - Simplestreams Sync Charm |
Fix Committed
|
Undecided
|
Chad Smith | ||
Landscape Charm |
Fix Released
|
Undecided
|
Chad Smith | ||
landscape-client-charm |
Fix Released
|
Undecided
|
Chad Smith |
Bug Description
I saw the following error when installing landscape-client, which uses charm-helper:
2014-09-18 07:34:50 INFO install Cannot add PPA: 'ppa:landscape/
2014-09-18 07:34:50 INFO install Please check that the PPA name or format is correct.
2014-09-18 07:34:50 INFO install Traceback (most recent call last):
2014-09-18 07:34:50 INFO install File "/var/lib/
2014-09-18 07:34:50 INFO install sys.exit(
2014-09-18 07:34:50 INFO install File "/var/lib/
2014-09-18 07:34:50 INFO install self._hooks[
2014-09-18 07:34:50 INFO install File "/var/lib/
2014-09-18 07:34:50 INFO install add_apt_
2014-09-18 07:34:50 INFO install File "/var/lib/
2014-09-18 07:34:50 INFO install return add_source(url, key)
2014-09-18 07:34:50 INFO install File "/var/lib/
2014-09-18 07:34:50 INFO install subprocess.
2014-09-18 07:34:50 INFO install File "/usr/lib/
2014-09-18 07:34:50 INFO install raise CalledProcessEr
2014-09-18 07:34:50 INFO install subprocess.
2014-09-18 07:34:50 ERROR juju.worker.uniter uniter.go:486 hook failed: exit status 1
When I retried the hook it succeeded, so it was probably a networking error. add_source() should retry adding it, in case there are network failures.
Related branches
- Eric Snow (community): Approve
- David Britton (community): Approve
-
Diff: 230 lines (+91/-39)2 files modifiedcharmhelpers/fetch/ubuntu.py (+51/-31)
tests/fetch/test_fetch.py (+40/-8)
- OpenStack Charmers: Pending requested
-
Diff: 10125 lines (+5920/-1725)74 files modifiedcharm-helpers-sync.yaml (+1/-0)
charmhelpers/__init__.py (+11/-13)
charmhelpers/contrib/__init__.py (+11/-13)
charmhelpers/contrib/charmsupport/__init__.py (+11/-13)
charmhelpers/contrib/charmsupport/nrpe.py (+103/-34)
charmhelpers/contrib/charmsupport/volumes.py (+11/-13)
charmhelpers/contrib/hahelpers/__init__.py (+11/-13)
charmhelpers/contrib/hahelpers/apache.py (+30/-17)
charmhelpers/contrib/hahelpers/cluster.py (+70/-23)
charmhelpers/contrib/network/__init__.py (+11/-13)
charmhelpers/contrib/network/ip.py (+99/-42)
charmhelpers/contrib/openstack/__init__.py (+11/-13)
charmhelpers/contrib/openstack/alternatives.py (+11/-13)
charmhelpers/contrib/openstack/amulet/__init__.py (+11/-13)
charmhelpers/contrib/openstack/amulet/deployment.py (+200/-69)
charmhelpers/contrib/openstack/amulet/utils.py (+354/-38)
charmhelpers/contrib/openstack/context.py (+313/-127)
charmhelpers/contrib/openstack/exceptions.py (+21/-0)
charmhelpers/contrib/openstack/files/__init__.py (+11/-13)
charmhelpers/contrib/openstack/files/check_haproxy.sh (+7/-5)
charmhelpers/contrib/openstack/ha/__init__.py (+13/-0)
charmhelpers/contrib/openstack/ha/utils.py (+139/-0)
charmhelpers/contrib/openstack/ip.py (+60/-25)
charmhelpers/contrib/openstack/keystone.py (+178/-0)
charmhelpers/contrib/openstack/neutron.py (+57/-23)
charmhelpers/contrib/openstack/templates/__init__.py (+11/-13)
charmhelpers/contrib/openstack/templates/haproxy.cfg (+19/-11)
charmhelpers/contrib/openstack/templates/memcached.conf (+53/-0)
charmhelpers/contrib/openstack/templates/openstack_https_frontend (+5/-0)
charmhelpers/contrib/openstack/templates/openstack_https_frontend.conf (+5/-0)
charmhelpers/contrib/openstack/templates/section-keystone-authtoken (+8/-5)
charmhelpers/contrib/openstack/templates/section-keystone-authtoken-legacy (+10/-0)
charmhelpers/contrib/openstack/templates/section-keystone-authtoken-mitaka (+20/-0)
charmhelpers/contrib/openstack/templates/wsgi-openstack-api.conf (+100/-0)
charmhelpers/contrib/openstack/templating.py (+19/-15)
charmhelpers/contrib/openstack/utils.py (+1163/-151)
charmhelpers/contrib/python/__init__.py (+11/-13)
charmhelpers/contrib/python/packages.py (+59/-26)
charmhelpers/contrib/storage/__init__.py (+11/-13)
charmhelpers/contrib/storage/linux/__init__.py (+11/-13)
charmhelpers/contrib/storage/linux/ceph.py (+766/-72)
charmhelpers/contrib/storage/linux/loopback.py (+21/-13)
charmhelpers/contrib/storage/linux/lvm.py (+11/-13)
charmhelpers/contrib/storage/linux/utils.py (+16/-18)
charmhelpers/core/__init__.py (+11/-13)
charmhelpers/core/decorators.py (+11/-13)
charmhelpers/core/files.py (+11/-13)
charmhelpers/core/fstab.py (+11/-13)
charmhelpers/core/hookenv.py (+157/-19)
charmhelpers/core/host.py (+482/-150)
charmhelpers/core/host_factory/centos.py (+56/-0)
charmhelpers/core/host_factory/ubuntu.py (+56/-0)
charmhelpers/core/hugepage.py (+13/-13)
charmhelpers/core/kernel.py (+34/-30)
charmhelpers/core/kernel_factory/centos.py (+17/-0)
charmhelpers/core/kernel_factory/ubuntu.py (+13/-0)
charmhelpers/core/services/__init__.py (+11/-13)
charmhelpers/core/services/base.py (+11/-13)
charmhelpers/core/services/helpers.py (+25/-18)
charmhelpers/core/strutils.py (+11/-13)
charmhelpers/core/sysctl.py (+11/-13)
charmhelpers/core/templating.py (+40/-24)
charmhelpers/core/unitdata.py (+11/-14)
charmhelpers/fetch/__init__.py (+43/-302)
charmhelpers/fetch/archiveurl.py (+12/-14)
charmhelpers/fetch/bzrurl.py (+48/-50)
charmhelpers/fetch/centos.py (+171/-0)
charmhelpers/fetch/giturl.py (+33/-37)
charmhelpers/fetch/snap.py (+122/-0)
charmhelpers/fetch/ubuntu.py (+364/-0)
charmhelpers/osplatform.py (+25/-0)
charmhelpers/payload/__init__.py (+11/-13)
charmhelpers/payload/archive.py (+11/-13)
charmhelpers/payload/execd.py (+14/-15)
- 🤖 Landscape Builder: Approve (test results)
- Eric Snow (community): Approve
-
Diff: 3080 lines (+1633/-771)34 files modifiedcharm-helpers.yaml (+1/-0)
charmhelpers/__init__.py (+11/-13)
charmhelpers/contrib/__init__.py (+11/-13)
charmhelpers/contrib/hahelpers/__init__.py (+11/-13)
charmhelpers/contrib/hahelpers/apache.py (+30/-17)
charmhelpers/contrib/hahelpers/cluster.py (+70/-23)
charmhelpers/core/__init__.py (+11/-13)
charmhelpers/core/decorators.py (+11/-13)
charmhelpers/core/files.py (+11/-13)
charmhelpers/core/fstab.py (+11/-13)
charmhelpers/core/hookenv.py (+73/-14)
charmhelpers/core/host.py (+327/-126)
charmhelpers/core/host_factory/centos.py (+56/-0)
charmhelpers/core/host_factory/ubuntu.py (+56/-0)
charmhelpers/core/hugepage.py (+11/-13)
charmhelpers/core/kernel.py (+34/-30)
charmhelpers/core/kernel_factory/centos.py (+17/-0)
charmhelpers/core/kernel_factory/ubuntu.py (+13/-0)
charmhelpers/core/services/__init__.py (+11/-13)
charmhelpers/core/services/base.py (+11/-13)
charmhelpers/core/services/helpers.py (+11/-13)
charmhelpers/core/strutils.py (+11/-13)
charmhelpers/core/sysctl.py (+11/-13)
charmhelpers/core/templating.py (+19/-16)
charmhelpers/core/unitdata.py (+11/-14)
charmhelpers/fetch/__init__.py (+42/-309)
charmhelpers/fetch/archiveurl.py (+11/-13)
charmhelpers/fetch/bzrurl.py (+31/-23)
charmhelpers/fetch/centos.py (+171/-0)
charmhelpers/fetch/giturl.py (+15/-16)
charmhelpers/fetch/snap.py (+122/-0)
charmhelpers/fetch/ubuntu.py (+364/-0)
charmhelpers/osplatform.py (+25/-0)
lib/apt.py (+2/-1)
tags: | added: cloud-installer landscape |
Changed in autopilot-log-analyser: | |
status: | New → In Progress |
importance: | Undecided → Low |
assignee: | nobody → Ursula Junque (ursinha) |
Changed in autopilot-log-analyser: | |
status: | In Progress → Fix Committed |
Changed in autopilot-log-analyser: | |
status: | Fix Committed → In Progress |
assignee: | Ursula Junque (ursinha) → Francis Ginther (fginther) |
Changed in autopilot-log-analyser: | |
status: | In Progress → Fix Committed |
Changed in autopilot-log-analyser: | |
status: | Fix Committed → In Progress |
Changed in charm-helpers: | |
assignee: | nobody → Chad Smith (chad.smith) |
status: | New → In Progress |
Changed in charm-helpers: | |
status: | In Progress → Fix Committed |
status: | Fix Committed → Fix Released |
Changed in autopilot-log-analyser: | |
status: | In Progress → Fix Released |
Changed in landscape-client-charm: | |
assignee: | nobody → Chad Smith (chad.smith) |
status: | New → In Progress |
Changed in landscape-charm: | |
assignee: | nobody → Chad Smith (chad.smith) |
status: | New → In Progress |
Changed in glance-simplestreams-sync-charm: | |
status: | New → In Progress |
assignee: | nobody → Chad Smith (chad.smith) |
Changed in landscape-client-charm: | |
status: | In Progress → Fix Released |
Changed in landscape-charm: | |
status: | In Progress → Fix Committed |
Changed in landscape-charm: | |
status: | Fix Committed → Fix Released |
Hello @adam-collard,
How recurring does this happens? Do you think the helper library should deal with possible networking errors?
Thanks