comma separated config becomes unwieldy with more than few certs

Bug #1778633 reported by Paul Gear
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
autocert-charm
Fix Released
Medium
Unassigned

Bug Description

At the moment cert_auth_pairs & cert_kubernetes_names must be comma-separated lists. After more than 2 certificates this makes line wrapping rather messy, e.g.

  cert_auth_pairs: foo.example.com=ooph9iNgei3Fah9eegohb4thoshieRoquee4yupheegiesau3pok4ueng9aafoh3, bar.example.com=wohfeeb7Thuk7PieChia4mai3sheig4ohyu4ohpah3ooTohch4thei4ohvoo9Ve3, baz.example.com=xooxih7esah3xog4eghahyeehuPohdeej3iey9ahF4aizaYaew3eingee3shuaL7
  cert_kubernetes_names: foo.example.com=production/foo-example-com-tls,
bar.example.com=production/bar-example-com-tls, baz.example.com=production/baz-example-com-tls

It would be preferred for readability and easy sorting if these could be yaml lists:

  cert_auth_pairs:
    - bar.example.com=wohfeeb7Thuk7PieChia4mai3sheig4ohyu4ohpah3ooTohch4thei4ohvoo9Ve3
    - baz.example.com=xooxih7esah3xog4eghahyeehuPohdeej3iey9ahF4aizaYaew3eingee3shuaL7
    - foo.example.com=ooph9iNgei3Fah9eegohb4thoshieRoquee4yupheegiesau3pok4ueng9aafoh3
  cert_kubernetes_names:
    - bar.example.com=production/bar-example-com-tls
    - baz.example.com=production/baz-example-com-tls
    - foo.example.com=production/foo-example-com-tls

Related branches

Revision history for this message
Joel Sing (jsing) wrote :

Given the existing deployment and original support for comma separate lists, we'd need to also maintain backwards compatibility, however it should be possible to determine what type of content has been supplied and support both.

Changed in autocert-charm:
importance: Undecided → Medium
status: New → Triaged
Joel Sing (jsing)
summary: - yaml config becomes unwieldy with more than few certs
+ comma separated config becomes unwieldy with more than few certs
Joel Sing (jsing)
Changed in autocert-charm:
status: Triaged → Fix Committed
Revision history for this message
Joel Sing (jsing) wrote :

cert_auth_pairs, cert_additional_names and cert_kubernetes_names all now support YAML lists or CSV. It is also worth noting that CSV works with multiline input:

  www1.example.com=abcdef,
  www2.example.com=123456

Changed in autocert-charm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.