autopkgtest-cloud-worker charm doesn't update worker config if net-name changes

[Brian Murray]

In charms/focal/autopkgtest-cloud-worker/reactive/autopkgtest_cloud_worker.py there is the following code:

413 @when_any(
414 "config.changed.worker-default-flavor",
415 "config.changed.worker-big-flavor",
416 "config.changed.worker-args",
417 "config.changed.worker-setup-command",
418 "config.changed.worker-setup-command2",
419 "config.changed.releases",
420 "config.changed.n-workers",
421 "config.changed.lxd-remotes",
422 "config.changed.mirror",
423 )
424 @when_any("config.set.nova-rcs", "config.set.lxd-remotes")
425 def write_worker_config():

and later on we can see /NET_NAME/ being replaced with config().get("net-name") however that isn't a trigger for this function.

I think we'd want to add "config.changed.net-name" to @when_any. However, this is a bit complicated to test because we'd have to update the charm etc....

[Skia (hyask)]

This was done in 205705d07d6dae2624a27f10a6721ca35d3d96a0, and deployed for months now.